From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 120BF3BB32 for ; Tue, 16 Jul 2024 07:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721115948; cv=none; b=ef+kNXn4B8kMGHtkTzwQGW/UaZbRLhGTBgzGsWoifo1KVOaUnBz4G6KIoiuerx+tTOdTvtroEvn8IRT+xogI7RBRI5zrgKc5tMYQkeaG5Z3u85vMNyVBmMa0sogy4GCgpPDleCtmfz7w2li5xBsRhPEi8QneH0MCBin9yxno/Uc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721115948; c=relaxed/simple; bh=86MUwza1xWsJAaFKgS4rDz0o1jK2RJQSPKS8NDzal6g=; h=Date:Message-Id:To:Cc:Subject:From:In-Reply-To:References: Mime-Version:Content-Type; b=e34281fdMFaukyUMLg+InZOjOL/kgz8sQy5eJF456oXELuQ8/7W6QaA81eQpmO6FaDJWjaGDjAc5aCP0bFgz9KqocYNAV1k46pUrx96L8C8VUhxGVNGuyZ/hy5Uc9HawbrgcuOv0ZCmz/8Ll7ZFTIsUD1t3AfuhMI42daW0mVv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LsLf3Ekv; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LsLf3Ekv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721115945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z+V++ss0Y+nF3bHAtu1rHuXiHCzOFsrcCTkSe7rWi5E=; b=LsLf3EkvpO4oDAyyhzmwRDSCRzw1uYZIYpT1c1EEH5/NNN25COufRVPVp96BHRqtgNxy9q jwQGRWeVqhGtPi829/CVn62zvovAdxy2zsB6klLoI8QveESQmgh7ulCfgDShe7rU8TIXnH 13JLJYERLdm3HS93A0iYZBiaxj5uXhU= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-298-_65BbCPSNj-Vc_gZhuxkeA-1; Tue, 16 Jul 2024 03:45:43 -0400 X-MC-Unique: _65BbCPSNj-Vc_gZhuxkeA-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-79f006f9f14so1037763885a.0 for ; Tue, 16 Jul 2024 00:45:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721115942; x=1721720742; h=content-transfer-encoding:mime-version:references:in-reply-to:from :subject:cc:to:message-id:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=z+V++ss0Y+nF3bHAtu1rHuXiHCzOFsrcCTkSe7rWi5E=; b=mSKJnUO/pWZmDof2Cm01qc4rt4yXXmNeV6sCI1NsxOhTD5DquxrKo1fo1dLB+xkp7q 541VIHs+2fwv0z3fc4JPV/E0FJ01ehO2/4CTC9uzQJlDlDL1vpo9ey0Y+8hBDYU1qFGX SqdXjKERsEkx4n318G7bcintVY8eHcotjRonQZhO0O5YY6H0WtuXE64cPIE32+gZvmjo bhTwhGxvjfPZENA4xBgP4cavZ9/fDotVznjATB8nJcnqUw3Zp0rd0cFnz6g7+ZSV+pXp vPXCUzkE2qFytNYYsbUr4B5w7IV1fS+pJtFE6XvnIEl+9CkDgZK4jDVxSgRKJhR215A1 GM8Q== X-Forwarded-Encrypted: i=1; AJvYcCV5jEZeI7xrjTXICZQFOjoV8dkdm7yO37dUeVH6Yk81TDz4c2R0+AuLF+GWRxsjHIR8jk20ndoQDhQwfzEjRNgPECNrQasDk/E9bnow X-Gm-Message-State: AOJu0YzEo3knlYwtpUiicW4IUKnvmDJ/Fue9f7nxU/6uepOK+OJ3bQAR bgqtlGhFd5P9OZ0nEbcHDM/7oht/BcV9bUowzi3FOBgiwpIJXyeof1cYyb5pIAgIt1zI9uGnQrR VipyqbDBlONzDeltpM8JfcCNrDBhJ2CVSawa4Dhx95TcX4zEvPauWgsQEpOkraOE4uhP9aodA X-Received: by 2002:a05:620a:2987:b0:79e:ff18:a510 with SMTP id af79cd13be357-7a17ca0990bmr122367985a.2.1721115942388; Tue, 16 Jul 2024 00:45:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHja7LIrw3Q4bZ6oSnFrulhGf/6KoTTkPi7QV9BQCaqrfjnWFBtckwybN/MOQzLHKDVIObrtA== X-Received: by 2002:a05:620a:2987:b0:79e:ff18:a510 with SMTP id af79cd13be357-7a17ca0990bmr122365585a.2.1721115942034; Tue, 16 Jul 2024 00:45:42 -0700 (PDT) Received: from localhost ([240d:1a:c0d:9f00:523b:c871:32d4:ccd0]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7a160bdd7fesm270250585a.65.2024.07.16.00.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jul 2024 00:45:41 -0700 (PDT) Date: Tue, 16 Jul 2024 16:45:35 +0900 (JST) Message-Id: <20240716.164535.1952205982608398288.syoshida@redhat.com> To: tung.q.nguyen@endava.com Cc: jmaloy@redhat.com, ying.xue@windriver.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] tipc: Return non-zero value from tipc_udp_addr2str() on error From: Shigeru Yoshida In-Reply-To: References: <20240716020905.291388-1-syoshida@redhat.com> X-Mailer: Mew version 6.9 on Emacs 29.4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hi Tung, On Tue, 16 Jul 2024 07:35:50 +0000, Tung Nguyen wrote: >>tipc_udp_addr2str() should return non-zero value if the UDP media address is invalid. Otherwise, a buffer overflow access can occur in >>tipc_media_addr_printf(). Fix this by returning 1 on an invalid UDP media address. >> >>Fixes: d0f91938bede ("tipc: add ip/udp media type") >>Signed-off-by: Shigeru Yoshida >>--- >> net/tipc/udp_media.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >>diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c index b849a3d133a0..439f75539977 100644 >>--- a/net/tipc/udp_media.c >>+++ b/net/tipc/udp_media.c >>@@ -135,8 +135,11 @@ static int tipc_udp_addr2str(struct tipc_media_addr *a, char *buf, int size) >> snprintf(buf, size, "%pI4:%u", &ua->ipv4, ntohs(ua->port)); >> else if (ntohs(ua->proto) == ETH_P_IPV6) >> snprintf(buf, size, "%pI6:%u", &ua->ipv6, ntohs(ua->port)); >>- else >>+ else { >> pr_err("Invalid UDP media address\n"); >>+ return 1; > Please use -EINVAL instead. Other addr2str functions like tipc_eth_addr2str() use 1, so I followed convention. But -EINVAL is more appropriate, as you say. Thanks, Shigeru