mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shenghao Ding <shenghao-ding@ti.com>
To: <broonie@kernel.org>
Cc: <andriy.shevchenko@linux.intel.com>, <lgirdwood@gmail.com>,
	<perex@perex.cz>, <pierre-louis.bossart@linux.intel.com>,
	<13916275206@139.com>, <zhourui@huaqin.com>,
	<alsa-devel@alsa-project.org>, <i-salazar@ti.com>,
	<linux-kernel@vger.kernel.org>, <j-chadha@ti.com>,
	<liam.r.girdwood@intel.com>, <jaden-yue@ti.com>,
	<yung-chuan.liao@linux.intel.com>, <dipa@ti.com>,
	<yuhsuan@google.com>, <henry.lo@ti.com>, <tiwai@suse.de>,
	<baojun.xu@ti.com>, <soyer@irl.hu>, <Baojun.Xu@fpt.com>,
	<judyhsiao@google.com>, <navada@ti.com>,
	<cujomalainey@google.com>, <aanya@ti.com>, <nayeem.mahmud@ti.com>,
	<savyasanchi.shukla@netradyne.com>, <flaviopr@microsoft.com>,
	<jesse-ji@ti.com>, <darren.ye@mediatek.com>,
	<antheas.dk@gmail.com>, Shenghao Ding <shenghao-ding@ti.com>
Subject: [PATCH v1] ASoc: tas2781: Add TAS2563 into the Header
Date: Tue, 16 Jul 2024 14:41:17 +0800	[thread overview]
Message-ID: <20240716064120.158-1-shenghao-ding@ti.com> (raw)

Add TAS2563 into the Header in case of misunderstanding and add
channel No information for error debug in tasdevice_dev_read.

Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>

---
v1:
 - Add TAS2563 into the Header
 - Add channel no into the log in tasdevice_dev_read for error debug
---
 sound/soc/codecs/tas2781-comlib.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/codecs/tas2781-comlib.c b/sound/soc/codecs/tas2781-comlib.c
index 1fbf4560f5cc..58abbc098a91 100644
--- a/sound/soc/codecs/tas2781-comlib.c
+++ b/sound/soc/codecs/tas2781-comlib.c
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 //
-// TAS2781 Common functions for HDA and ASoC Audio drivers
+// TAS2563/TAS2781 Common functions for HDA and ASoC Audio drivers
 //
 // Copyright 2023 - 2024 Texas Instruments, Inc.
 //
@@ -64,8 +64,8 @@ static int tasdevice_change_chn_book(struct tasdevice_priv *tas_priv,
 			 */
 			ret = regmap_write(map, TASDEVICE_PAGE_SELECT, 0);
 			if (ret < 0) {
-				dev_err(tas_priv->dev, "%s, E=%d\n",
-					__func__, ret);
+				dev_err(tas_priv->dev, "%s, E=%d channel:%d\n",
+					__func__, ret, chn);
 				goto out;
 			}
 		}
-- 
2.34.1


             reply	other threads:[~2024-07-16  6:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16  6:41 Shenghao Ding [this message]
2024-07-30 12:29 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240716064120.158-1-shenghao-ding@ti.com \
    --to=shenghao-ding@ti.com \
    --cc=13916275206@139.com \
    --cc=Baojun.Xu@fpt.com \
    --cc=aanya@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=antheas.dk@gmail.com \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=cujomalainey@google.com \
    --cc=darren.ye@mediatek.com \
    --cc=dipa@ti.com \
    --cc=flaviopr@microsoft.com \
    --cc=henry.lo@ti.com \
    --cc=i-salazar@ti.com \
    --cc=j-chadha@ti.com \
    --cc=jaden-yue@ti.com \
    --cc=jesse-ji@ti.com \
    --cc=judyhsiao@google.com \
    --cc=lgirdwood@gmail.com \
    --cc=liam.r.girdwood@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=navada@ti.com \
    --cc=nayeem.mahmud@ti.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=savyasanchi.shukla@netradyne.com \
    --cc=soyer@irl.hu \
    --cc=tiwai@suse.de \
    --cc=yuhsuan@google.com \
    --cc=yung-chuan.liao@linux.intel.com \
    --cc=zhourui@huaqin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®