From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A5522E651 for ; Wed, 17 Jul 2024 13:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721223698; cv=none; b=hpyOOB4Xg5F3gdJuYFTWjD23hLuTCmj7Iboa4RLVd5p5rFhlCdcvsSyRvu5vCqiUPyWLS/m/+nc9JPQ2KCnwHA5+Ia7z+WK6KfVbns+9OZRL0zdtpSObtEcSv8Q0gzdT2247x1zH5V7mj07gPgmhUWE85P6XTCfLdJTogp59MV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721223698; c=relaxed/simple; bh=DhFAFincECZnQ6N49VF4grcrX0gUzdPQUKGTG1ehRj4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L+2mi9d8Tjc+UzsA0SFb4AhKvKc6FCBwzCmiD1bpMmUGCTSMzsMNB+EaElnMz/sTrERmKRRqNIPCAtEaesafFj61nxXiyFtUNzFheXJDO9QS11rVd4agKUPfMPu43v9gDxpK/FYZkpN2d/N0+m/HDZKBB8yY45j/GXNd5QXr/L0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jZFxwgq9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jZFxwgq9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87893C32782; Wed, 17 Jul 2024 13:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1721223697; bh=DhFAFincECZnQ6N49VF4grcrX0gUzdPQUKGTG1ehRj4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jZFxwgq95Ibm8DxAIz0dpK6HySb7NzNCCqxllNt22nUm8ds/1y6iZxG+wriUrwTpd BrATBfTZcE3O7wwDjF7QORaBBVm2UXafuBtVNArSZRJaOm+L4wpeTW+KdQs1spCU6V boFFngYIvYS4fDNTY2IuXaFcqn6qrP0VRPK0iZcqIdVKtw2cXZXmHtpqD3nbG5WfPz omItYCB7ZfwdOEI8zASBWU1LBmL3qAKUrTQBmcEUMhS9ZWiEcLnw4Opak5aBSia7gP FZdZBHIorXa0v2gHnx4bUSWpopkSf8jNCQWsAHcpGc0YD43INl1qjm32y9uxwkVCuw +XAbtQQEp3q3Q== Date: Wed, 17 Jul 2024 06:41:35 -0700 From: Nathan Chancellor To: Vamsi Krishna Attunuru Cc: Arnd Bergmann , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , Jeff Johnson Subject: Re: [EXTERNAL] Re: [PATCH] misc: mrvl-cn10k-dpi: resolve compilation issues on 32-bit ARM Message-ID: <20240717134135.GA24892@thelio-3990X> References: <20240717045225.138799-1-vattunuru@marvell.com> <2024071709-nephew-scooter-5c6b@gregkh> <22bf9a24-b4db-4017-b5a9-1b03e6f20bff@app.fastmail.com> <024d85a1-6a4e-4552-a5dd-adebfb195be8@app.fastmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jul 17, 2024 at 12:17:08PM +0000, Vamsi Krishna Attunuru wrote: > > > >-----Original Message----- > >From: Arnd Bergmann > >Sent: Wednesday, July 17, 2024 5:20 PM > >To: Vamsi Krishna Attunuru ; Greg Kroah-Hartman > > > >Cc: linux-kernel@vger.kernel.org; Nathan Chancellor ; > >Jeff Johnson > >Subject: Re: [EXTERNAL] Re: [PATCH] misc: mrvl-cn10k-dpi: resolve > >compilation issues on 32-bit ARM > > > >On Wed, Jul 17, 2024, at 13: 45, Vamsi Krishna Attunuru wrote: > > Neither of > >them worked in our case, HW folks also confirmed that only > 64bit access > >work correctly. > I will just include the header that address the compilation > > > >On Wed, Jul 17, 2024, at 13:45, Vamsi Krishna Attunuru wrote: > >> > >> Neither of them worked in our case, HW folks also confirmed that only > >> 64bit access work correctly. > >> I will just include the header that address the compilation errors > >> with ARCH=arm, anyways nobody will use this driver on 32-bit kernel. > > > >Please just use a Kconfig dependency then. If the device requires 64-bit > >register access, then the driver should not use the fallback. > > Ack, since it needs to skip compilation on 32-bit platforms, can you please > confirm below change is suffice or not. > > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -588,7 +588,7 @@ config NSM > config MARVELL_CN10K_DPI > tristate "Octeon CN10K DPI driver" > depends on PCI > - depends on ARCH_THUNDER || COMPILE_TEST > + depends on (ARCH_THUNDER || COMPILE_TEST) && 64BIT I think it would be a little clearer written as depends on ARCH_THUNDER || (COMPILE_TEST && 64BIT) because ARCH_THUNDER can only be defined when 64BIT is set. Regardless though, that should resolve the issue. Tested-by: Nathan Chancellor Cheers, Nathan