From: Kevin Hilman <khilman@baylibre.com>
To: linux-gpio@vger.kernel.org
Cc: Keerthy <j-keerthy@ti.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 1/2] gpiolib: expose for_each_gpio_desc() to drivers
Date: Wed, 17 Jul 2024 17:09:32 -0700 [thread overview]
Message-ID: <20240718000935.2573288-2-khilman@baylibre.com> (raw)
In-Reply-To: <20240718000935.2573288-1-khilman@baylibre.com>
The for_each_gpio_desc() iterator is a convenient helper and is also
useful for GPIO controller drivers. Move this helper from the
internal gpiolib.h to driver.h.
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
---
drivers/gpio/gpiolib.h | 5 -----
include/linux/gpio/driver.h | 5 +++++
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h
index 48e086c2f416..c68be135e137 100644
--- a/drivers/gpio/gpiolib.h
+++ b/drivers/gpio/gpiolib.h
@@ -115,11 +115,6 @@ struct gpio_array {
unsigned long invert_mask[];
};
-#define for_each_gpio_desc(gc, desc) \
- for (unsigned int __i = 0; \
- __i < gc->ngpio && (desc = gpiochip_get_desc(gc, __i)); \
- __i++) \
-
#define for_each_gpio_desc_with_flag(gc, desc, flag) \
for_each_gpio_desc(gc, desc) \
if (!test_bit(flag, &desc->flags)) {} else
diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 0032bb6e7d8f..3e7e58be31b4 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -813,6 +813,11 @@ const char *gpio_device_get_label(struct gpio_device *gdev);
struct gpio_device *gpio_device_find_by_label(const char *label);
struct gpio_device *gpio_device_find_by_fwnode(const struct fwnode_handle *fwnode);
+#define for_each_gpio_desc(gc, desc) \
+ for (unsigned int __i = 0; \
+ __i < gc->ngpio && (desc = gpiochip_get_desc(gc, __i)); \
+ __i++) \
+
#else /* CONFIG_GPIOLIB */
#include <asm/bug.h>
--
2.45.2
next parent reply other threads:[~2024-07-18 0:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240718000935.2573288-1-khilman@baylibre.com>
2024-07-18 0:09 ` Kevin Hilman [this message]
2024-07-18 4:52 ` Dhruva Gole
2024-07-18 0:09 ` [PATCH 2/2] gpio: davinci: handle wakeup-source property, detect wake IRQs Kevin Hilman
2024-07-18 5:35 ` Dhruva Gole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240718000935.2573288-2-khilman@baylibre.com \
--to=khilman@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=j-keerthy@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®