From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+dd73570cf9918519e789@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [fs?] WARNING: lock held when returning to user space in ns_ioctl
Date: Thu, 18 Jul 2024 19:03:17 +0800 [thread overview]
Message-ID: <20240718110318.1438-1-hdanton@sina.com> (raw)
In-Reply-To: <00000000000077c88b061d7b893e@google.com>
On Wed, 17 Jul 2024 18:31:24 -0700
> syzbot found the following issue on:
>
> HEAD commit: 51835949dda3 Merge tag 'net-next-6.11' of git://git.kernel..
> git tree: upstream
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15ef5b4e980000
#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 51835949dda3
--- x/fs/nsfs.c
+++ y/fs/nsfs.c
@@ -188,8 +188,10 @@ static long ns_ioctl(struct file *filp,
tsk = find_task_by_vpid(arg);
else
tsk = find_task_by_pid_ns(arg, pid_ns);
- if (!tsk)
+ if (!tsk) {
+ rcu_read_unlock();
break;
+ }
switch (ioctl) {
case NS_GET_PID_FROM_PIDNS:
--
next prev parent reply other threads:[~2024-07-18 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 1:31 syzbot
2024-07-18 4:18 ` [syzbot] " syzbot
2024-07-18 11:03 ` Hillf Danton [this message]
2024-07-18 12:00 ` [syzbot] [fs?] " syzbot
2024-07-26 9:16 ` Christian Brauner
[not found] <CAJwTMzpbq-bRitZBAqfqvjW_1zifEXbJ=+ZAcW5ndRO=yAraBw@mail.gmail.com>
2024-07-18 11:11 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240718110318.1438-1-hdanton@sina.com \
--to=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+dd73570cf9918519e789@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®