From: Nathan Chancellor <nathan@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>,
Ho-Ren Chuang <horen.chuang@linux.dev>,
"Huang, Ying" <ying.huang@intel.com>,
Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>,
Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH v2] ACPI: HMAT: Mark hmat_set_default_dram_perf() as __init
Date: Fri, 19 Jul 2024 18:04:25 -0700 [thread overview]
Message-ID: <20240719-fix-modpost-warning-default_dram_nodes-v2-1-792ff57a50b0@kernel.org> (raw)
After commit 823430c8e9d9 ("memory tier: consolidate the initialization
of memory tiers"), there is a modpost warning when
hmat_set_default_dram_perf() is not inlined into its callsite, as it
appears that default_dram_nodes may be accessed after its memory has
been freed.
WARNING: modpost: vmlinux: section mismatch in reference: hmat_set_default_dram_perf+0x18 (section: .text) -> default_dram_nodes (section: .init.data)
The single callsite, hmat_init(), is __init, so this warning is not a
problem in reality but it is easily solvable by marking
hmat_set_default_dram_perf() as __init, which should have been done when
this function was added in commit 3718c02dbd4c ("acpi, hmat: calculate
abstract distance with HMAT").
Fixes: 823430c8e9d9 ("memory tier: consolidate the initialization of memory tiers")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202406292310.hlRATeZJ-lkp@intel.com/
Reviewed-by: Huang, Ying <ying.huang@intel.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
Changes in v2:
- The problematic change appears to be merged into mm-stable, so I added
a fixes tag and updated the commit message with the stable hash.
- Add Ying's reviewed-by tag.
- Link to v1: https://lore.kernel.org/r/20240710-fix-modpost-warning-default_dram_nodes-v1-1-8961453cc82d@kernel.org
---
drivers/acpi/numa/hmat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/numa/hmat.c b/drivers/acpi/numa/hmat.c
index a2f9e7a4b479..ca0c0ea3e1ef 100644
--- a/drivers/acpi/numa/hmat.c
+++ b/drivers/acpi/numa/hmat.c
@@ -933,7 +933,7 @@ static int hmat_callback(struct notifier_block *self,
return NOTIFY_OK;
}
-static int hmat_set_default_dram_perf(void)
+static __init int hmat_set_default_dram_perf(void)
{
int rc;
int nid, pxm;
---
base-commit: 30d77b7eef019fa4422980806e8b7cdc8674493e
change-id: 20240710-fix-modpost-warning-default_dram_nodes-38b6faffe3da
Best regards,
--
Nathan Chancellor <nathan@kernel.org>
reply other threads:[~2024-07-20 1:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240719-fix-modpost-warning-default_dram_nodes-v2-1-792ff57a50b0@kernel.org \
--to=nathan@kernel.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=akpm@linux-foundation.org \
--cc=horen.chuang@linux.dev \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rafael@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®