mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mateusz Majewski <m.majewski2@samsung.com>
To: linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Mateusz Majewski <m.majewski2@samsung.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>
Subject: [PATCH 2/6] drivers/thermal/exynos: use tmu_temp_mask consistently
Date: Fri, 19 Jul 2024 14:08:46 +0200	[thread overview]
Message-ID: <20240719120853.1924771-3-m.majewski2@samsung.com> (raw)
In-Reply-To: <20240719120853.1924771-1-m.majewski2@samsung.com>

Some of the usages in sanitize_temp_error were missed, probably because
the boards being used never actually exceeded 255 in their trimming
information. This is needed for Exynos 850 support, which uses 9-bit
temperature codes.

Signed-off-by: Mateusz Majewski <m.majewski2@samsung.com>
---
 drivers/thermal/samsung/exynos_tmu.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 9b7ca93a72f1..61606a9b9a00 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -237,17 +237,17 @@ static void sanitize_temp_error(struct exynos_tmu_data *data, u32 trim_info)
 
 	data->temp_error1 = trim_info & tmu_temp_mask;
 	data->temp_error2 = ((trim_info >> EXYNOS_TRIMINFO_85_SHIFT) &
-				EXYNOS_TMU_TEMP_MASK);
+				tmu_temp_mask);
 
 	if (!data->temp_error1 ||
 	    (data->min_efuse_value > data->temp_error1) ||
 	    (data->temp_error1 > data->max_efuse_value))
-		data->temp_error1 = data->efuse_value & EXYNOS_TMU_TEMP_MASK;
+		data->temp_error1 = data->efuse_value & tmu_temp_mask;
 
 	if (!data->temp_error2)
 		data->temp_error2 =
 			(data->efuse_value >> EXYNOS_TRIMINFO_85_SHIFT) &
-			EXYNOS_TMU_TEMP_MASK;
+			tmu_temp_mask;
 }
 
 static int exynos_tmu_initialize(struct platform_device *pdev)
-- 
2.45.1


  parent reply	other threads:[~2024-07-19 12:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20240719120944eucas1p29318fb588150b15f60f637fbea48271f@eucas1p2.samsung.com>
2024-07-19 12:08 ` [PATCH 0/6] Add initial Exynos 850 support to the thermal driver Mateusz Majewski
     [not found]   ` <CGME20240719120945eucas1p2aa5e35f78daa7ec1ea07f512180db468@eucas1p2.samsung.com>
2024-07-19 12:08     ` [PATCH 1/6] drivers/thermal/exynos: use DEFINE_SIMPLE_DEV_PM_OPS Mateusz Majewski
2024-07-22 18:41       ` Sam Protsenko
2024-07-24  6:04       ` Anand Moon
     [not found]   ` <CGME20240719120945eucas1p16058905c95c92840679831ae3383a67a@eucas1p1.samsung.com>
2024-07-19 12:08     ` Mateusz Majewski [this message]
2024-07-22 19:03       ` [PATCH 2/6] drivers/thermal/exynos: use tmu_temp_mask consistently Sam Protsenko
     [not found]   ` <CGME20240719120946eucas1p1b565fa653d33aa2155cd3bb172c29d14@eucas1p1.samsung.com>
2024-07-19 12:08     ` [PATCH 3/6] drivers/thermal/exynos: check IS_ERR(data->clk) consistently Mateusz Majewski
2024-07-22 21:03       ` Sam Protsenko
2024-07-23 14:17         ` Mateusz Majewski
2024-07-23 14:51           ` Sam Protsenko
     [not found]   ` <CGME20240719120947eucas1p1344134823e100feaf49238de0e226431@eucas1p1.samsung.com>
2024-07-19 12:08     ` [PATCH 4/6] dt-bindings: thermal: samsung,exynos: add exynos850-tmu string Mateusz Majewski
2024-07-22 21:26       ` Sam Protsenko
     [not found]   ` <CGME20240719120948eucas1p13f3dc8f3aba56027da720d36c6057040@eucas1p1.samsung.com>
2024-07-19 12:08     ` [PATCH 5/6] drivers/thermal/exynos: add initial Exynos 850 support Mateusz Majewski
2024-07-23  0:02       ` Sam Protsenko
2024-07-23 14:16         ` Mateusz Majewski
2024-07-23 15:23           ` Sam Protsenko
2024-07-23 16:47             ` Sam Protsenko
2024-07-24 15:30             ` Mateusz Majewski
2024-07-25  0:42               ` Sam Protsenko
2024-07-24 15:30         ` Mateusz Majewski
2024-07-25  0:56           ` Sam Protsenko
     [not found]   ` <CGME20240719120949eucas1p1b061c716ac55b4a79ba57c407c0b2d91@eucas1p1.samsung.com>
2024-07-19 12:08     ` [PATCH 6/6] dt-bindings: thermal: samsung,exynos: remove outdated information on trip point count Mateusz Majewski
2024-07-22 21:34       ` Sam Protsenko
2024-07-23  3:08       ` Rob Herring
2024-07-23 14:17         ` Mateusz Majewski
2024-07-23 19:24           ` Rob Herring
2024-07-24 15:31             ` Mateusz Majewski
2024-07-22 18:39   ` [PATCH 0/6] Add initial Exynos 850 support to the thermal driver Sam Protsenko
2024-07-23 14:16     ` Mateusz Majewski
2024-07-23 14:44       ` Sam Protsenko
2024-07-24 15:31         ` Mateusz Majewski
2024-07-25  1:06           ` Sam Protsenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240719120853.1924771-3-m.majewski2@samsung.com \
    --to=m.majewski2@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=bzolnier@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®