mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Zqiang <qiang.zhang1211@gmail.com>
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
	paulmck@kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] nsfs: Fix the missed rcu_read_unlock() invoking in ns_ioctl()
Date: Mon, 22 Jul 2024 11:54:03 +0200	[thread overview]
Message-ID: <20240722095403.dmnewl7g7ti6fqat@quack3> (raw)
In-Reply-To: <20240722085149.32479-1-qiang.zhang1211@gmail.com>

On Mon 22-07-24 16:51:49, Zqiang wrote:
> Currently, the syzbot report follow wanings:
> 
> Voluntary context switch within RCU read-side critical section!
> WARNING: CPU: 0 PID: 3460 at kernel/rcu/tree_plugin.h:330 rcu_note_context_switch+0x354/0x49c
> Call trace:
> rcu_note_context_switch+0x354/0x49c kernel/rcu/tree_plugin.h:330
> __schedule+0xb0/0x850 kernel/sched/core.c:6417
> __schedule_loop kernel/sched/core.c:6606 [inline]
> schedule+0x34/0x104 kernel/sched/core.c:6621
> do_notify_resume+0xe4/0x164 arch/arm64/kernel/entry-common.c:136
> exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline]
> exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline]
> el0_interrupt+0xc4/0xc8 arch/arm64/kernel/entry-common.c:797
> __el0_irq_handler_common+0x18/0x24 arch/arm64/kernel/entry-common.c:802
> el0t_64_irq_handler+0x10/0x1c arch/arm64/kernel/entry-common.c:807
> el0t_64_irq+0x19c/0x1a0 arch/arm64/kernel/entry.S:599
> 
> This happens when the tsk pointer is null and a call to rcu_read_unlock()
> is missed in ns_ioctl(), this commit therefore invoke rcu_read_lock()
> when tsk pointer is null.
> 
> Reported-by: syzbot+784d0a1246a539975f05@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=784d0a1246a539975f05
> Fixes: ca567df74a28 ("nsfs: add pid translation ioctls")
> Signed-off-by: Zqiang <qiang.zhang1211@gmail.com>

Thanks for the fix but this should be already fixed by commit
280e36f0d5b9971 ("nsfs: use cleanup guard") that was recently merged
upstream.

								Honza

> ---
>  fs/nsfs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/nsfs.c b/fs/nsfs.c
> index a4a925dce331..e228d06f0949 100644
> --- a/fs/nsfs.c
> +++ b/fs/nsfs.c
> @@ -188,8 +188,10 @@ static long ns_ioctl(struct file *filp, unsigned int ioctl,
>  			tsk = find_task_by_vpid(arg);
>  		else
>  			tsk = find_task_by_pid_ns(arg, pid_ns);
> -		if (!tsk)
> +		if (!tsk) {
> +			rcu_read_unlock();
>  			break;
> +		}
>  
>  		switch (ioctl) {
>  		case NS_GET_PID_FROM_PIDNS:
> -- 
> 2.17.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

      reply	other threads:[~2024-07-22  9:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-22  8:51 Zqiang
2024-07-22  9:54 ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240722095403.dmnewl7g7ti6fqat@quack3 \
    --to=jack@suse.cz \
    --cc=brauner@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=qiang.zhang1211@gmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®