From: Andrew Morton <akpm@linux-foundation.org>
To: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Pasha Tatashin <pasha.tatashin@soleen.com>,
jpoimboe@kernel.org, kent.overstreet@linux.dev,
peterz@infradead.org, nphamcs@gmail.com,
cerasuolodomenico@gmail.com, surenb@google.com,
lizhijian@fujitsu.com, willy@infradead.org, vbabka@suse.cz,
ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v4] vmstat: Kernel stack usage histogram
Date: Tue, 23 Jul 2024 17:09:13 -0700 [thread overview]
Message-ID: <20240723170913.07bfd0ba8a2557285263912e@linux-foundation.org> (raw)
In-Reply-To: <ud5csdd23fjb2gin4uuxsocm4hvsy22bk4plfjv5zvqd2egqri@hpavorxrrprw>
On Fri, 19 Jul 2024 15:04:40 -0700 Shakeel Butt <shakeel.butt@linux.dev> wrote:
> > > Any specific reason to add this function in header?
> >
> > For performance reasons to keep it inlined into stack_not_used() which
> > is also defined as inline function in this header.
> >
>
> Is this really that performance critical?
Nope. stack_not_used() is for CONFIG_DEBUG_STACK_USAGE and
stack_not_used() is slow.
I suggest that stack_not_used() (and hence kstack_histogram()) be
uninlined. This can be a followup patch.
next prev parent reply other threads:[~2024-07-24 0:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 20:26 Pasha Tatashin
2024-07-18 21:44 ` Kent Overstreet
2024-07-18 23:36 ` Shakeel Butt
2024-07-19 2:55 ` Pasha Tatashin
2024-07-19 22:04 ` Shakeel Butt
2024-07-24 0:09 ` Andrew Morton [this message]
2024-07-24 0:10 ` Andrew Morton
2024-07-24 6:46 ` Andrew Morton
2024-07-24 14:43 ` Pasha Tatashin
2024-07-24 16:59 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723170913.07bfd0ba8a2557285263912e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cerasuolodomenico@gmail.com \
--cc=jpoimboe@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizhijian@fujitsu.com \
--cc=nphamcs@gmail.com \
--cc=pasha.tatashin@soleen.com \
--cc=peterz@infradead.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®