mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
To: jtornosm@redhat.com
Cc: UNGLinuxDriver@microchip.com, andrew@lunn.ch,
	davem@davemloft.net, edumazet@google.com,
	gregkh@linuxfoundation.org, kuba@kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	lucas.demarchi@intel.com, mcgrof@kernel.org,
	netdev@vger.kernel.org, pabeni@redhat.com,
	woojung.huh@microchip.com
Subject: Re: [PATCH] net: usb: lan78xx: add weak dependency with micrel phy module
Date: Wed, 24 Jul 2024 18:10:19 +0200	[thread overview]
Message-ID: <20240724161020.442958-1-jtornosm@redhat.com> (raw)
In-Reply-To: <20240724145458.440023-1-jtornosm@redhat.com>

Hello Florian,

> What is the difference with the existing MODULE_SOFTDEP() which has pre 
> and post qualifiers and seems just as fit?
MODULE_SOFTDEP (with pre and/or post qualifiers as you say) causes the
modules to be directly loaded.

MODULES_WEAKDEP doesn't cause the modules to be loaded. 
The load will be done later, if necessary, by other mechanisms in the kernel.
For example for the commented case, the associated phy is read using mdio bus
and then the associated phy module is loaded during runtime  by means of the
function phy_request_driver_module.
It is just informing to user applications, like dracut, about this in order to
be able to prepare the complete and correct initramfs. 
Keep in mind that these applications have no way of knowing about this situation
and if the phy is not included in this case, the driver will not work at
initramfs stage.
If we used MODULE_SOFTDEP the modules would be loaded in advance even if they
were not necessary.
For the commented case, I have included only one phy because it is the hardware
that I have, but other phy devices (modules) are possible and they can be some.

Thanks 

Best regards
José Ignacio


  reply	other threads:[~2024-07-24 16:10 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-24 10:23 Jose Ignacio Tornos Martinez
2024-07-24 11:49 ` Andrew Lunn
2024-07-24 13:36   ` Greg KH
2024-07-24 14:46     ` Jose Ignacio Tornos Martinez
2024-07-24 15:31       ` Florian Fainelli
2024-07-24 14:54     ` Jose Ignacio Tornos Martinez
2024-07-24 16:10       ` Jose Ignacio Tornos Martinez [this message]
2024-07-24 22:57         ` Andrew Lunn
2024-07-25  4:25           ` Lucas De Marchi
2024-07-25  4:42             ` Florian Fainelli
2024-07-25  6:50               ` Lucas De Marchi
2024-07-25  9:53                 ` Paolo Abeni
2024-07-26 11:33                   ` Andrew Lunn
2024-07-26 12:15                     ` Jose Ignacio Tornos Martinez
2024-07-26 20:59                       ` Andrew Lunn
2024-07-27 17:15                         ` Dragan Simic
2024-07-27 23:29                           ` Andrew Lunn
2024-07-28 14:10                             ` Dragan Simic
2024-07-28 19:45                               ` Andrew Lunn
2024-07-28 20:46                                 ` Dragan Simic
2024-07-28 20:57                                   ` Andrew Lunn
2024-07-29  4:43                                     ` Dragan Simic
2024-07-29  6:13                                       ` Greg KH
2024-07-29  6:29                                         ` Dragan Simic
2024-07-29  8:34                                           ` Jose Ignacio Tornos Martinez
2024-07-29  9:28                                             ` Dragan Simic
2024-07-29 12:32                                               ` Jose Ignacio Tornos Martinez
2024-07-29 18:56                                                 ` Andrew Lunn
2024-07-30  7:55                                                   ` Jose Ignacio Tornos Martinez
2024-07-28  7:37                       ` Masahiro Yamada
2024-07-28  9:53                         ` Dragan Simic
2024-07-26 14:49           ` Jakub Kicinski
2024-07-26 21:15             ` Andrew Lunn
2024-07-29  8:37               ` Jose Ignacio Tornos Martinez
2024-07-29 12:42                 ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240724161020.442958-1-jtornosm@redhat.com \
    --to=jtornosm@redhat.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lucas.demarchi@intel.com \
    --cc=mcgrof@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=woojung.huh@microchip.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®