mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nas Chung <nas.chung@chipsnmedia.com>
To: mchehab@kernel.org, hverkuil@xs4all.nl,
	bryan.odonoghue@linaro.org, linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Nas Chung <nas.chung@chipsnmedia.com>
Subject: [RESEND v3 2/3] media: qcom: venus: Fix uninitialized variable warning
Date: Thu, 25 Jul 2024 15:10:33 +0900	[thread overview]
Message-ID: <20240725061034.461-3-nas.chung@chipsnmedia.com> (raw)
In-Reply-To: <20240725061034.461-1-nas.chung@chipsnmedia.com>

Avoid uninitialized variable when both V4L2_TYPE_IS_OUTPUT() and
V4L2_TYPE_IS_CAPTURE() return false.

Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com>
---
 drivers/media/platform/qcom/venus/vdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
index d12089370d91..b72b579018e3 100644
--- a/drivers/media/platform/qcom/venus/vdec.c
+++ b/drivers/media/platform/qcom/venus/vdec.c
@@ -161,7 +161,7 @@ find_format_by_index(struct venus_inst *inst, unsigned int index, u32 type)
 
 		if (V4L2_TYPE_IS_OUTPUT(type)) {
 			valid = venus_helper_check_codec(inst, fmt[i].pixfmt);
-		} else if (V4L2_TYPE_IS_CAPTURE(type)) {
+		} else {
 			valid = venus_helper_check_format(inst, fmt[i].pixfmt);
 
 			if (fmt[i].pixfmt == V4L2_PIX_FMT_QC10C &&
-- 
2.25.1


  parent reply	other threads:[~2024-07-25  6:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-25  6:10 [RESEND v3 0/3] Change V4L2_TYPE_IS_CAPTURE condition Nas Chung
2024-07-25  6:10 ` [RESEND v3 1/3] media: uapi: v4l: " Nas Chung
2024-07-25  6:10 ` Nas Chung [this message]
2024-08-29 10:30   ` [RESEND v3 2/3] media: qcom: venus: Fix uninitialized variable warning Bryan O'Donoghue
2024-08-30  4:26     ` Nas Chung
2024-07-25  6:10 ` [RESEND v3 3/3] media: uapi: v4l: Fix V4L2_TYPE_IS_OUTPUT condition Nas Chung
2024-08-29  9:03 ` [RESEND v3 0/3] Change V4L2_TYPE_IS_CAPTURE condition Nas Chung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240725061034.461-3-nas.chung@chipsnmedia.com \
    --to=nas.chung@chipsnmedia.com \
    --cc=bryan.odonoghue@linaro.org \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®