From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Davis <goldside000@outlook.com>
Cc: urezki@gmail.com, hch@infradead.org, hannes@cmpxchg.org,
yosryahmed@google.com, nphamcs@gmail.com,
chengming.zhou@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Capitalize letters for readability
Date: Thu, 25 Jul 2024 13:21:24 -0700 [thread overview]
Message-ID: <20240725132124.b0d317ba1d9e7d1651b71a65@linux-foundation.org> (raw)
In-Reply-To: <PH7P223MB1039C0F7DAC6FFB32F61DE48F7AB2@PH7P223MB1039.NAMP223.PROD.OUTLOOK.COM>
On Thu, 25 Jul 2024 15:28:29 -0400 Steven Davis <goldside000@outlook.com> wrote:
> This patch capitalizes the first letters of error and
> debug messages to enhance readability. This is important
> for adhering to the style of other error messages in the
> kernel, and making it easier and clearer to read the
> messages upon the (likely dark) terminal.
hm.
x1:/usr/src/25> grep " pr_[^(]*.*: [A-Z]" mm/*.c | wc -l
34
x1:/usr/src/25> grep " pr_[^(]*.*: [a-z]" mm/*.c | wc -l
97
If we're going to make this change then we should change everything,
add a checkpatch rule, etc.
But I do think such a change is too trivial to justify churning the
code around.
next prev parent reply other threads:[~2024-07-25 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-25 19:28 Steven Davis
2024-07-25 20:21 ` Andrew Morton [this message]
2024-07-25 20:49 ` Steven Davis
2024-07-25 21:27 ` Andrew Morton
2024-07-26 12:08 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240725132124.b0d317ba1d9e7d1651b71a65@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=goldside000@outlook.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=urezki@gmail.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®