From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2D00D194C7B; Tue, 30 Jul 2024 09:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722332036; cv=none; b=rn796ZPfUcco80w6uFJ/q7h1SO+XFBI3mLvIO8x2677d/E1K6GNxpgvYIlT90msXr5UG1IOA27rdCACDKeRXPIUhrmh0i2b04W4/ignHfYbVBtU5Rpwd7JcC31QFUZnwO60Ef5eIMYiNJjTPxbbTqbfrWm1arQS1kfuwNpXNpwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722332036; c=relaxed/simple; bh=rM3mLTcUdd4k/AdUQARh++4y+dw/gvLuDQpxof6VST4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F/fcALrza6VhGY+LdNuPzjnBsrN0VQGVGsaNhWIL1VZlQhPNCx/cTYVA1HrCYwpjIMApYAJzyqeEul2UGpdAll3b/iABw5ZXq/1SQ52DqRvFf4Jwck7vic4yvqJUGpHaKv0IkQBGX2Smbi7QTZau2b6hRQYZMLJ1sWdmm91rpCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4B45A1515; Tue, 30 Jul 2024 02:34:19 -0700 (PDT) Received: from thinkcentre-m93p.cambridge.arm.com (thinkcentre-m93p.cambridge.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB8EB3F5A1; Tue, 30 Jul 2024 02:33:52 -0700 (PDT) From: Luke Parkin To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, Luke Parkin Subject: [PATCH v4 2/5] firmware: arm_scmi: Add support for tracking metrics Date: Tue, 30 Jul 2024 10:33:39 +0100 Message-Id: <20240730093342.3558162-3-luke.parkin@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240730093342.3558162-1-luke.parkin@arm.com> References: <20240730093342.3558162-1-luke.parkin@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a new optional config option for tracking, configurable at build. Add methods for counting key metrics Signed-off-by: Luke Parkin --- v3->v4 Rename to counters rather than statistic tracking Move enum tracker to common.h Move stats array into debug v2->v3 Switch to an enum & array method of storing statistics v1->v2 Config option now depends on DEBUG_FS Add scmi_log_stats rather than if(IS_ENABLED) Move location of scmi_debug_stats in the scmi_info struct --- drivers/firmware/arm_scmi/Kconfig | 11 +++++++++++ drivers/firmware/arm_scmi/common.h | 13 +++++++++++++ drivers/firmware/arm_scmi/driver.c | 2 ++ 3 files changed, 26 insertions(+) diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig index aa5842be19b2..b3ccd565b986 100644 --- a/drivers/firmware/arm_scmi/Kconfig +++ b/drivers/firmware/arm_scmi/Kconfig @@ -55,6 +55,17 @@ config ARM_SCMI_RAW_MODE_SUPPORT_COEX operate normally, thing which could make an SCMI test suite using the SCMI Raw mode support unreliable. If unsure, say N. +config ARM_SCMI_DEBUG_COUNTERS + bool "Enable SCMI debug tracking" + select ARM_SCMI_NEED_DEBUGFS + depends on DEBUG_FS + help + Enables debug tracking for the SCMI subsystem. + + Enable this option to create a new debugfs directory which contains + several useful debug counters. This can be helpful for debugging and + SCMI monitoring. If unsure, say N. + config ARM_SCMI_HAVE_TRANSPORT bool help diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h index b5ac25dbc1ca..8f80bf0ddddd 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -301,6 +301,19 @@ extern const struct scmi_desc scmi_optee_desc; void scmi_rx_callback(struct scmi_chan_info *cinfo, u32 msg_hdr, void *priv); +enum debug_counters { + SCMI_DEBUG_COUNTERS_LAST +}; + +#ifdef CONFIG_ARM_SCMI_DEBUG_COUNTERS +static inline void scmi_inc_count(atomic_t *arr, int stat) +{ + atomic_inc(&arr[stat]); +} +#else +static inline void scmi_inc_count(atomic_t *arr, int stat) {} +#endif + enum scmi_bad_msg { MSG_UNEXPECTED = -1, MSG_INVALID = -2, diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 56a93d20bf23..958b2ac92050 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -117,12 +117,14 @@ struct scmi_protocol_instance { * @name: Name of this SCMI instance * @type: Type of this SCMI instance * @is_atomic: Flag to state if the transport of this instance is atomic + * @counters: An array of atomic_c's used for tracking statistics (if enabled) */ struct scmi_debug_info { struct dentry *top_dentry; const char *name; const char *type; bool is_atomic; + atomic_t counters[SCMI_DEBUG_COUNTERS_LAST]; }; /** -- 2.34.1