From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C40CD198833; Tue, 30 Jul 2024 09:33:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722332038; cv=none; b=l0vboPOGAHtwkddYkYK2kvx49wB+IcD+gB34a/KU2FXWTLydAzQGzfbknW9WhnvPhzmLKIuSXnrBDHQZcRY8lIZ5zXlamalERXUq7VjbnRMzACccfwNME/KXNKYViS9K2NBY+YkXY622J3EmEYeo8suOh7+0TmPc2U1I6aUDzC4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722332038; c=relaxed/simple; bh=LPRWG4F+dpSvEk97l2V/NBwOlRg/3B0C6UONxmpAK7E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VfB0zoFpjYsTJ/VyBmpT19FTv1rQZ1BJcnMqg/A/AC6IfYn5Lxi4l6NmTS0ExJeCwgpn96dYwejwiO9KYp+8frrtbfmA3d3YExTVudldBB5mb37Ei+1zzx45IXwERKSEDpG5SaA66FxstJz651bvM9r3nC9GcSahQZPfFjKmYwo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CEEAE153B; Tue, 30 Jul 2024 02:34:21 -0700 (PDT) Received: from thinkcentre-m93p.cambridge.arm.com (thinkcentre-m93p.cambridge.arm.com [10.1.197.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3B5AC3F5A1; Tue, 30 Jul 2024 02:33:55 -0700 (PDT) From: Luke Parkin To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, cristian.marussi@arm.com, Luke Parkin Subject: [PATCH v4 4/5] firmware: arm_scmi: Create debugfs files for counts Date: Tue, 30 Jul 2024 10:33:41 +0100 Message-Id: <20240730093342.3558162-5-luke.parkin@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240730093342.3558162-1-luke.parkin@arm.com> References: <20240730093342.3558162-1-luke.parkin@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Create debugfs files for the metrics in the debug_counters array Signed-off-by: Luke Parkin --- v3->v4 Use new locations for debug array Use counter instead of stats v2->v3 Add extra statistics also added in v3 v1->v2 Only create stats pointer if stats are enabled Move stats debugfs creation into a seperate helper function --- drivers/firmware/arm_scmi/driver.c | 38 ++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index 5acd3d324def..ec6434692d1a 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -2847,6 +2847,41 @@ static int scmi_device_request_notifier(struct notifier_block *nb, return NOTIFY_OK; } +static void scmi_debugfs_counters_setup(struct scmi_debug_info *dbg, + struct dentry *trans) +{ + struct dentry *counters; + + counters = debugfs_create_dir("counters", trans); + + debugfs_create_atomic_t("sent_ok", 0400, counters, + &dbg->counters[SENT_OK]); + debugfs_create_atomic_t("sent_fail", 0400, counters, + &dbg->counters[SENT_FAIL]); + debugfs_create_atomic_t("sent_fail_polling_unsupported", 0400, counters, + &dbg->counters[SENT_FAIL_POLLING_UNSUPPORTED]); + debugfs_create_atomic_t("sent_fail_channel_not_found", 0400, counters, + &dbg->counters[SENT_FAIL_CHANNEL_NOT_FOUND]); + debugfs_create_atomic_t("response_ok", 0400, counters, + &dbg->counters[RESPONSE_OK]); + debugfs_create_atomic_t("notif_ok", 0400, counters, + &dbg->counters[NOTIF_OK]); + debugfs_create_atomic_t("dlyd_resp_ok", 0400, counters, + &dbg->counters[DLYD_RESPONSE_OK]); + debugfs_create_atomic_t("xfers_resp_timeout", 0400, counters, + &dbg->counters[XFERS_RESPONSE_TIMEOUT]); + debugfs_create_atomic_t("response_polled_ok", 0400, counters, + &dbg->counters[RESPONSE_POLLED_OK]); + debugfs_create_atomic_t("err_msg_unexpected", 0400, counters, + &dbg->counters[ERR_MSG_UNEXPECTED]); + debugfs_create_atomic_t("err_msg_invalid", 0400, counters, + &dbg->counters[ERR_MSG_INVALID]); + debugfs_create_atomic_t("err_msg_nomem", 0400, counters, + &dbg->counters[ERR_MSG_NOMEM]); + debugfs_create_atomic_t("err_protocol", 0400, counters, + &dbg->counters[ERR_PROTOCOL]); +} + static void scmi_debugfs_common_cleanup(void *d) { struct scmi_debug_info *dbg = d; @@ -2913,6 +2948,9 @@ static struct scmi_debug_info *scmi_debugfs_common_setup(struct scmi_info *info) debugfs_create_u32("rx_max_msg", 0400, trans, (u32 *)&info->rx_minfo.max_msg); + if (IS_ENABLED(CONFIG_ARM_SCMI_DEBUG_COUNTERS)) + scmi_debugfs_counters_setup(dbg, trans); + dbg->top_dentry = top_dentry; if (devm_add_action_or_reset(info->dev, -- 2.34.1