mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: LKML <linux-kernel@vger.kernel.org>,
	Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>
Cc: "Masami Hiramatsu" <mhiramat@kernel.org>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Ajay Kaher" <ajay.kaher@broadcom.com>,
	"Mathias Krause" <minipli@grsecurity.net>,
	"Ilkka Naulapää" <digirigawa@gmail.com>,
	"Linus Torvalds" <torvalds@linux-foundation.org>,
	"Al Viro" <viro@zeniv.linux.org.uk>,
	regressions@leemhuis.info,
	"Dan Carpenter" <dan.carpenter@linaro.org>,
	"Beau Belgrave" <beaub@linux.microsoft.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Alexey Makhalov" <alexey.makhalov@broadcom.com>,
	"Vasavi Sirnapalli" <vasavi.sirnapalli@broadcom.com>
Subject: Re: [PATCH v3] tracing: Have format file honor EVENT_FILE_FL_FREED
Date: Tue, 30 Jul 2024 11:15:08 -0400	[thread overview]
Message-ID: <20240730111508.75448556@gandalf.local.home> (raw)
In-Reply-To: <20240730110657.3b69d3c1@gandalf.local.home>

On Tue, 30 Jul 2024 11:06:57 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> Link: https://lore.kernel.org/all/20240719204701.1605950-1-minipli@grsecurity.net/
> 
> Cc: stable@vger.kernel.org
> Fixes: b63db58e2fa5d ("eventfs/tracing: Add callback for release of an eventfs_inode")
> Reported-by: Mathias Krause <minipli@grsecurity.net>
> Tested-by: Mathias Krause <minipli@grsecurity.net>

Hi Mathias,

I kept your "Tested-by" tag because you did test the part that fixes the
bug you reported. I just added on top of that one to handle other possibly
cases. Let me know if you want me to drop that tag, or if you tested this
version as well.

Thanks,

-- Steve


> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> ---
> Changes since v3: https://lore.kernel.org/20240726132811.306a449e@rorschach.local.home
> 
> - After inspecting the code, there's several users of event_file_data()
>   that return the trace_event_file descriptor when it could be set to be
>   freed. Add a new helper function: event_file_file() that will make sure
>   the event_mutex is held and check the flag and return NULL if the file is
>   freed.

  reply	other threads:[~2024-07-30 15:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-30 15:06 Steven Rostedt
2024-07-30 15:15 ` Steven Rostedt [this message]
2024-07-30 20:40   ` Mathias Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240730111508.75448556@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=ajay.kaher@broadcom.com \
    --cc=alexey.makhalov@broadcom.com \
    --cc=beaub@linux.microsoft.com \
    --cc=dan.carpenter@linaro.org \
    --cc=digirigawa@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=minipli@grsecurity.net \
    --cc=regressions@leemhuis.info \
    --cc=torvalds@linux-foundation.org \
    --cc=vasavi.sirnapalli@broadcom.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®