From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A25CA48; Thu, 1 Aug 2024 00:09:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722470964; cv=none; b=iJoRXO87cE6NlZobT0ppMxfySk+QCmNcu65tmBnAHMLGBgIhjFXNRMxZrIAGEHVbRYw2qKJov3dlerv+kDywmv0pq+1prlIGHE1Ccb4vZAk6g603eXWXWaZH8NpaA3bv1V/pLGQFUccZNTPBg1htYxxyzRnWoBuzouIE/vUSlF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722470964; c=relaxed/simple; bh=sBY+V2qU4wz571bmWgNjlbPpEzs7l4V4b9kJKruLpuI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H8g8iV+iLJnVtwdm7yAOal2AlLywBUMqJURG6aVWqomIEOB2ge1fFEgtSYlQ7im2kgYVelVti3HdHRmkHbY4/nTkaDbiEc+hoXfl76FwYP3ObtGNUW8rDTjXhYE4g5LEM1ZVrc8CBRNdtqd9xYX96nNg1reDaEPzyp2SC9gLFfw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XLet+QaI; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XLet+QaI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7AC0C32786; Thu, 1 Aug 2024 00:09:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722470963; bh=sBY+V2qU4wz571bmWgNjlbPpEzs7l4V4b9kJKruLpuI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XLet+QaIT5QNtMCnSg0SMJEHTnyxaGh6qEhZzrLKpDPu81WGqir6OW/4whA9AmdLF nYK7Y7QK55Om/o77crR8Hp2AFLVQ+Rc0PUaMTBJIfmHuu6YNy1b+beyX9IBCo2inZB /Rj7LHGBnGjbH2q3QN8ukHWSzaB3IGIzm8dFPYXZvlJUT+d1mwiwqua+j3m7rZE2Z7 V8eIiJdINyczPVXAT9iuMKPnbpPdYEUQjDxiOGA6NZ4dMkB2tDSknHL8wV0jJNLpyo 7tfc5MdnUqlh1SjDTMgxBTTSLTy24ewyziKbMLKkI8ZBxv9Hm7QSPaFAbjQmKgIh+N YNjKbXQIVzuOQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alex Hung , Harry Wentland , Tom Chung , Daniel Wheeler , Alex Deucher , Sasha Levin , sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, hersenxs.wu@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.10 010/121] drm/amd/display: Check gpio_id before used as array index Date: Wed, 31 Jul 2024 19:59:08 -0400 Message-ID: <20240801000834.3930818-10-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801000834.3930818-1-sashal@kernel.org> References: <20240801000834.3930818-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.10.2 Content-Transfer-Encoding: 8bit From: Alex Hung [ Upstream commit 2a5626eeb3b5eec7a36886f9556113dd93ec8ed6 ] [WHY & HOW] GPIO_ID_UNKNOWN (-1) is not a valid value for array index and therefore should be checked in advance. This fixes 5 OVERRUN issues reported by Coverity. Reviewed-by: Harry Wentland Acked-by: Tom Chung Signed-off-by: Alex Hung Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c b/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c index 663c17f52779c..d19d5c1770222 100644 --- a/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c +++ b/drivers/gpu/drm/amd/display/dc/gpio/gpio_service.c @@ -239,6 +239,9 @@ static bool is_pin_busy( enum gpio_id id, uint32_t en) { + if (id == GPIO_ID_UNKNOWN) + return false; + return service->busyness[id][en]; } @@ -247,6 +250,9 @@ static void set_pin_busy( enum gpio_id id, uint32_t en) { + if (id == GPIO_ID_UNKNOWN) + return; + service->busyness[id][en] = true; } @@ -255,6 +261,9 @@ static void set_pin_free( enum gpio_id id, uint32_t en) { + if (id == GPIO_ID_UNKNOWN) + return; + service->busyness[id][en] = false; } @@ -263,7 +272,7 @@ enum gpio_result dal_gpio_service_lock( enum gpio_id id, uint32_t en) { - if (!service->busyness[id]) { + if (id != GPIO_ID_UNKNOWN && !service->busyness[id]) { ASSERT_CRITICAL(false); return GPIO_RESULT_OPEN_FAILED; } @@ -277,7 +286,7 @@ enum gpio_result dal_gpio_service_unlock( enum gpio_id id, uint32_t en) { - if (!service->busyness[id]) { + if (id != GPIO_ID_UNKNOWN && !service->busyness[id]) { ASSERT_CRITICAL(false); return GPIO_RESULT_OPEN_FAILED; } -- 2.43.0