From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94102134407; Thu, 1 Aug 2024 00:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722471366; cv=none; b=A6oSeYS9roCPtXyBc4kUsbrrw24Hr9J8Rsr4ON0qb/fmn9JTESrxC/OndnZTViMtbYEpJDx/YMrq4/borkSEob4ftWv8T6kajbdodQkY0NIPzltS5ccZa5zsg9bgnHYj6QgmEuWWMInD8n65eEqHzt017sDhi0sb74f2GulFXs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722471366; c=relaxed/simple; bh=BevY77iRPP2rcLSSLdc/Qw8M9iWbWGhbWK26o/OAXLQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iC8PVNG8twq9v6qFpjBcMePf0MRWtd62blCI6YbqBuswLohGzBBraWXDjkpRho0az+Pnt4kYv1USRQ5xHDWFDO1QdEcb+tSoqdmgiqJi9sp3M/JDgRNzKLR3fb4ZpOFjT06NacXrFK/Mz1bGM6mJ+16AHglnWwBhORc7dBKHzwY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=L6PDliWV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="L6PDliWV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76435C116B1; Thu, 1 Aug 2024 00:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722471366; bh=BevY77iRPP2rcLSSLdc/Qw8M9iWbWGhbWK26o/OAXLQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L6PDliWVkPxhq9W8L3IBIFwvjG66PZil7XgeILDiBh4bkD7DG9wm/NNZl7Ca752vw s6D3M99Kl6tuBQJ+YfweoEOXjdojmzhC3EhJOMF7KjGTek2aaX6rLiguMW4VDvQa38 eRsv29iDlhsPWsMYCcvYm7ptTByGuiwOjWTOqooBjOI1DU3fyqMYJIv5kzfKeNBY2P 6YdcEX/q9NIHR1u/PlE2Psp4caHUMg0Anp/TQtIKv+HSQqTeUnKzFkPFOh7ARseG8d prYzs1AUtm8walo0LJeBtJ6JEZ95ZcdMrMlqVUbEQShXOdYTulYxKPYn/ncEn3Cisg Wgg3OWCQmyUUA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Nicholas Kazlauskas , Ovidiu Bunea , Zaeem Mohamed , Daniel Wheeler , Alex Deucher , Sasha Levin , harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch, charlene.liu@amd.com, Qingqing.Zhuo@amd.com, wayne.lin@amd.com, ahmed.ahmed@amd.com, wenjing.liu@amd.com, daniel.miess@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 6.10 078/121] drm/amd/display: Disable DMCUB timeout for DCN35 Date: Wed, 31 Jul 2024 20:00:16 -0400 Message-ID: <20240801000834.3930818-78-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240801000834.3930818-1-sashal@kernel.org> References: <20240801000834.3930818-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.10.2 Content-Transfer-Encoding: 8bit From: Nicholas Kazlauskas [ Upstream commit 7c70e60fbf4bff1123f0e8d5cb1ae71df6164d7f ] [Why] DMCUB can intermittently take longer than expected to process commands. Old ASIC policy was to continue while logging a diagnostic error - which works fine for ASIC without IPS, but with IPS this could lead to a race condition where we attempt to access DCN state while it's inaccessible, leading to a system hang when the NIU port is not disabled or register accesses that timeout and the display configuration in an undefined state. [How] We need to investigate why these accesses take longer than expected, but for now we should disable the timeout on DCN35 to avoid this race condition. Since the waits happen only at lower interrupt levels the risk of taking too long at higher IRQ and causing a system watchdog timeout are minimal. Reviewed-by: Ovidiu Bunea Acked-by: Zaeem Mohamed Signed-off-by: Nicholas Kazlauskas Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c b/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c index 28c4599076989..915d68cc04e9c 100644 --- a/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c +++ b/drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c @@ -785,6 +785,7 @@ static const struct dc_debug_options debug_defaults_drv = { .ips2_entry_delay_us = 800, .disable_dmub_reallow_idle = false, .static_screen_wait_frames = 2, + .disable_timeout = true, }; static const struct dc_panel_config panel_config_defaults = { -- 2.43.0