From: David Gow <david@davidgow.net>
To: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
"Somalapuram Amaranath" <Amaranath.Somalapuram@amd.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Andi Shyti" <andi.shyti@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Cc: "David Gow" <david@ingeniumdigital.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Tvrtko Ursulin" <tursulin@ursulin.net>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] drm/i915: Fix ttm small BAR placement handling
Date: Sun, 4 Aug 2024 17:18:46 +0800 [thread overview]
Message-ID: <20240804091851.122186-1-david@davidgow.net> (raw)
From: David Gow <david@ingeniumdigital.com>
As described in [1], there have been a couple of regressions in the TTM
placement handling for i915, which adversely affect DG2 systems with
small BAR. In particular, performance become very poor when eviction
from the mappable BAR memory is required, as suboptimal placements can
be preferred, leading to thrashing. This often leads to hangs of >10s,
during which even the compositor is unusable.
These regressions were largely introduced during the flag rework in
commit a78a8da51b36 ("drm/ttm: replace busy placement with flags v6").
The first patch has already been sent out[2]. I'm resending it as part
of this series which fixes both known regressions.
Thanks to Justin Brewer for bisecting the issue.
Cheers,
-- David
[1]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11255
[2]: https://lore.kernel.org/dri-devel/20240722074540.15295-1-david@davidgow.net/
---
David Gow (2):
drm/i915: Allow evicting to use the requested placement
drm/i915: Attempt to get pages without eviction first
drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
--
2.46.0
next reply other threads:[~2024-08-04 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 9:18 David Gow [this message]
2024-08-04 9:18 ` [PATCH 1/2] drm/i915: Allow evicting to use the requested placement David Gow
2024-08-05 20:09 ` Cavitt, Jonathan
2024-08-04 9:18 ` [PATCH 2/2] drm/i915: Attempt to get pages without eviction first David Gow
2024-08-05 20:11 ` Cavitt, Jonathan
2024-08-06 16:14 ` [PATCH 0/2] drm/i915: Fix ttm small BAR placement handling Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240804091851.122186-1-david@davidgow.net \
--to=david@davidgow.net \
--cc=Amaranath.Somalapuram@amd.com \
--cc=andi.shyti@linux.intel.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=david@ingeniumdigital.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®