From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Felix Moessbauer <felix.moessbauer@siemens.com>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <frederic@kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
jan.kiszka@siemens.com
Subject: Re: [PATCH 1/2] hrtimer: Document, that PI boosted tasks have no timer slack
Date: Mon, 5 Aug 2024 15:27:49 +0200 [thread overview]
Message-ID: <20240805132749.jtD28XKa@linutronix.de> (raw)
In-Reply-To: <87cymn5div.ffs@tglx>
On 2024-08-05 15:02:00 [+0200], Thomas Gleixner wrote:
> On Mon, Aug 05 2024 at 14:41, Felix Moessbauer wrote:
> > The documentation of schedule_hrtimeout_range already states, that RT
> > and DL tasks do not have a timer slack. However, no information about PI
> > boosted tasks is given. The current implementation consistently ignores
> > the timer slack also for PI boosted tasks (all tasks with a rt priority
> > at time of programming the timer).
>
> Which is wrong. This condition should not use rt_task() it should use
> task_is_realtime() instead.
There is also the series 20240610192018.1567075-1-qyousef@layalina.io
> Thanks,
>
> tglx
Sebastian
next prev parent reply other threads:[~2024-08-05 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 12:41 [PATCH 0/2] hrtimer: More fixes for handling of timer slack of rt tasks Felix Moessbauer
2024-08-05 12:41 ` [PATCH 1/2] hrtimer: Document, that PI boosted tasks have no timer slack Felix Moessbauer
2024-08-05 13:02 ` Thomas Gleixner
2024-08-05 13:27 ` Sebastian Andrzej Siewior [this message]
2024-08-05 12:41 ` [PATCH 2/2] hrtimer: Ignore slack time for RT tasks in hrtimer_start_range_ns() Felix Moessbauer
2024-08-05 13:05 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805132749.jtD28XKa@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=felix.moessbauer@siemens.com \
--cc=frederic@kernel.org \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®