From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Anup Kulkarni <quic_anupkulk@quicinc.com>
Cc: manivannan.sadhasivam@linaro.org, thomas.kopp@microchip.com,
mailhol.vincent@wanadoo.fr, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_msavaliy@quicinc.com,
quic_vdadhani@quicinc.com
Subject: Re: [PATCH v1] can: mcp251xfd: Enable transceiver using gpio
Date: Tue, 6 Aug 2024 22:02:24 +0200 [thread overview]
Message-ID: <20240806-industrious-augmented-crane-44239a-mkl@pengutronix.de> (raw)
In-Reply-To: <20240806090339.785712-1-quic_anupkulk@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On 06.08.2024 14:33:39, Anup Kulkarni wrote:
> Ensure the CAN transceiver is active during mcp251xfd_open() and
> inactive during mcp251xfd_close() by utilizing
> mcp251xfd_transceiver_mode(). Adjust GPIO_0 to switch between
> NORMAL and STANDBY modes of transceiver.
There is still the gpio support patch pending, which I have to review
and test.
https://lore.kernel.org/all/20240522-mcp251xfd-gpio-feature-v3-0-8829970269c5@ew.tq-group.com/
After this has been merged, we can have a look at this patch.
It might actually not be needed anymore, as we can describe a CAN
transceiver switched by a GPIO in the DT. Hopefully we don't run into
some crazy circular dependencies or similar issues.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2024-08-06 20:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 9:03 Anup Kulkarni
2024-08-06 9:20 ` Christophe JAILLET
2024-08-06 11:03 ` Przemek Kitszel
2024-08-06 20:02 ` Marc Kleine-Budde [this message]
2024-09-09 11:20 ` Anup Kulkarni
2024-08-07 7:47 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806-industrious-augmented-crane-44239a-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=manivannan.sadhasivam@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_anupkulk@quicinc.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=thomas.kopp@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®