From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C14EF15D1 for ; Tue, 6 Aug 2024 05:57:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722923823; cv=none; b=gxoujVhhv0S+SbDylR8yif+2QM36R882gY4RZAGI5FFTxO/Vq9S4LrcYzzMjjEl60cAYwtNscvu+dQ13hvUUNhuUajrPSgZl8pR6iKU+0gokfzv2CsboaRdKj3B2YRbkkE1EAAtRtbxrVxV3cS6fn6xZWAwYJXk9UM8Fhq0E6k8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722923823; c=relaxed/simple; bh=0Hejww234DES1PvMhUh245HUseCRhbD8DLK4u6Op7/4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=C6vu8VDOt4TlZiKHlMjFpd5oPTNULPTZEeN2mnnyAWFw6KSS/Z0CfvxCp0cdCkWtZalNRqO3Dlnc/R5zgQ5PkuKm2skR2r3DU2rZhn4OLpuepGxZ7KeHnxm2s1JVKMmJs0qAE8NQOhN/6/sDwLVibLB2S25eXqPHJAEHzjKv3L4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z0b/J6Fp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z0b/J6Fp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECCD4C32786; Tue, 6 Aug 2024 05:57:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722923823; bh=0Hejww234DES1PvMhUh245HUseCRhbD8DLK4u6Op7/4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Z0b/J6Fp6towTBV4MzPGVYXKwddZrXbmJN3lrvlGMnmT5NF0RCvtzDN67nqqbIF8X tpaSL0Zm08Hq1vivs7cp+OMsnhs+0c3ChowrbHZGreE4Ce4Z092Wx2N/cN6dTa27ff BzNSP/nif+rL2JojCCAnE56QfXbcGBeExIh8NfekQkBijJBHTLYjrFYoeFg0X7X3O3 O8879yvWMCzc4bPWSU6pcBpC1Siy48WKGo/0Z+E2C75VTTG11+5Ccnaa9dHTFex+8a 69CzrO6CN93hRJwnzGZVP1ttwxUheroeQOrYUyIEkm6Y39lhAp6ufzKSC79HdaYi9J eEK1wk7L7gpBQ== Date: Tue, 6 Aug 2024 07:56:57 +0200 From: Mauro Carvalho Chehab To: Jonathan Cameron Cc: Shiju Jose , "Michael S. Tsirkin" , Ani Sinha , Dongjiu Geng , Igor Mammedov , "Peter Maydell" , Shannon Zhao , , , Subject: Re: [PATCH v5 3/7] arm/virt: Wire up GPIO error source for ACPI / GHES Message-ID: <20240806075657.2a43abcc@foz.lan> In-Reply-To: <20240805175400.000028ad@Huawei.com> References: <20240805175400.000028ad@Huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Em Mon, 5 Aug 2024 17:54:00 +0100 Jonathan Cameron escreveu: > On Fri, 2 Aug 2024 23:43:58 +0200 > Mauro Carvalho Chehab wrote: > > Do we need to rename this now there is a GED involved? > Is it even technically a GPIO any more? > Spec says in 18.3.2.7 > HW-reduced ACPI platforms signal the error using a GPIO > interrupt or another interrupt declared under > a generic event device (Interrupt-signaled ACPI events) > and goes on to say that a _CRS entry is used to > list the interrupt. > > Give the Generic Event Device has a _CRS > with aml_interrupt() as the type I think we should > even have the hest entry say it's an interrupt (external?) > rather than a gpio. True. I'll change patch description to: arm/virt: Wire up a GED error device for ACPI / GHES Adds support to ARM virtualization to allow handling a General Purpose Event (GPE) via GED error device. It is aligned with Linux Kernel patch: https://lore.kernel.org/lkml/1272350481-27951-8-git-send-email-ying.huang@intel.com/ As the spec at https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources revers to it as: "The implementation of Event notification requires the platform to define a device with PNP ID PNP0C33 in the ACPI namespace, referred to as the error device." > > Adds support to ARM virtualization to allow handling > > a General Purpose Event (GPE) via GED error device. > > > > It is aligned with Linux Kernel patch: > > https://lore.kernel.org/lkml/1272350481-27951-8-git-send-email-ying.huang@intel.com/ > > > > Co-authored-by: Mauro Carvalho Chehab > > Co-authored-by: Jonathan Cameron > > Cc: Jonathan Cameron > > Again, more or less fine with this > Signed-off-by: Jonathan Cameron > to go with that co-auth Thanks! Mauro