From: Andrew Morton <akpm@linux-foundation.org>
To: Barry Song <21cnbao@gmail.com>
Cc: David Hildenbrand <david@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Barry Song <v-songbaohua@oppo.com>,
Kairui Song <kasong@tencent.com>, Chris Li <chrisl@kernel.org>,
"Huang, Ying" <ying.huang@intel.com>,
Hugh Dickins <hughd@google.com>,
Kalesh Singh <kaleshsingh@google.com>,
Ryan Roberts <ryan.roberts@arm.com>
Subject: Re: [PATCH] mm: attempt to batch free swap entries for zap_pte_range()
Date: Tue, 6 Aug 2024 15:41:12 -0700 [thread overview]
Message-ID: <20240806154112.5d6e63b527c3a9501ef5a851@linux-foundation.org> (raw)
In-Reply-To: <CAGsJ_4xR949nPauJ4kZpcg3cRwvcrHHWU7oSazpfGR2Tv5XNTA@mail.gmail.com>
On Wed, 7 Aug 2024 04:44:44 +0800 Barry Song <21cnbao@gmail.com> wrote:
> > > +static bool try_batch_swap_entries_free(struct swap_info_struct *p,
> >
> > Why call it "p" here and not "si" like in the other code you are touching?
>
> that is because I found other _free_ functions are all using "p":
`p' sucks. "pointer to something". It's just lazy. In this context, "si"
has meaning; lots of it.
next prev parent reply other threads:[~2024-08-06 22:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 1:24 Barry Song
2024-08-06 12:56 ` David Hildenbrand
2024-08-06 20:44 ` Barry Song
2024-08-06 22:41 ` Andrew Morton [this message]
2024-08-06 22:23 ` Barry Song
2024-08-07 1:34 ` Barry Song
2024-08-06 7:23 zhiguojiang
2024-08-06 6:38 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806154112.5d6e63b527c3a9501ef5a851@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=21cnbao@gmail.com \
--cc=chrisl@kernel.org \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=kaleshsingh@google.com \
--cc=kasong@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=v-songbaohua@oppo.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®