mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Frank Li <Frank.li@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Shawn Guo <shawnguo@kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [PATCH 3/3] arm64: dts: layerscape: move dwc3 usb under glue layer node
Date: Wed, 7 Aug 2024 00:41:09 +0000	[thread overview]
Message-ID: <20240807004105.pea4z7oobw7n3qy6@synopsys.com> (raw)
In-Reply-To: <ZqkLT/2myU7S4uYu@lizhi-Precision-Tower-5810>

Hi Frank,

On Tue, Jul 30, 2024, Frank Li wrote:
> On Thu, Jul 11, 2024 at 03:38:46PM -0600, Rob Herring wrote:
> > On Wed, Jul 10, 2024 at 07:02:24PM -0400, Frank Li wrote:
> > > New usb glue layer driver support enable dma-coherent. So put dwc3 usb node
> > > under glue layer node and enable dma-coherent.
> > > 
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 43 ++++++++++++++++----------
> > >  1 file changed, 26 insertions(+), 17 deletions(-)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > index 70b8731029c4e..24b937032480f 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> > > @@ -615,24 +615,33 @@ gpio3: gpio@2320000 {
> > >  			little-endian;
> > >  		};
> > >  
> > > -		usb0: usb@3100000 {
> > > -			compatible = "fsl,ls1028a-dwc3", "snps,dwc3";
> > > -			reg = <0x0 0x3100000 0x0 0x10000>;
> > > -			interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
> > > -			snps,dis_rxdet_inp3_quirk;
> > > -			snps,quirk-frame-length-adjustment = <0x20>;
> > > -			snps,incr-burst-type-adjustment = <1>, <4>, <8>, <16>;
> > > -			status = "disabled";
> > > -		};
> > > +		usb {
> > > +			compatible = "fsl,ls1028a-dwc3";
> > > +			#address-cells = <2>;
> > > +			#size-cells = <2>;
> > > +			ranges;
> > 
> > No, the existing way is preferred unless you have actual glue/wrapper 
> > registers. Plus this breaks compatibility.
> 
> Actually, it has glue layer, such as wakeup controller. Remote wakeup have
> not implement at layerscape platform yet. But this register distribute to
> difference place with other module misc controller registers. It is
> difference for difference chips. I can think deep how to handle this. 
> 
> but anyways, it will break compatibility. I have not find good way to
> keep compatibility and add glue layer, such as wakeup support.
> 
> Frank
> 

Will this impact how the rest of the series look? If so, I'll wait until
you resolve this issue and review the rest.

BR,
Thinh

  reply	other threads:[~2024-08-07  0:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-10 23:02 [PATCH 0/3] usb: dwc3: add fsl,ls-dwc3 glue layer support Frank Li
2024-07-10 23:02 ` [PATCH 1/3] dt-bindings: usb: Add fsl,ls-dwc3.yaml for layerscape usb3 glue layer Frank Li
2024-07-12  9:24   ` Krzysztof Kozlowski
2024-07-10 23:02 ` [PATCH 2/3] usb: dwc3: of-simple: Add compatible string fsl,ls1028a-dwc3 Frank Li
2024-07-10 23:02 ` [PATCH 3/3] arm64: dts: layerscape: move dwc3 usb under glue layer node Frank Li
2024-07-11 21:38   ` Rob Herring
2024-07-30 15:48     ` Frank Li
2024-08-07  0:41       ` Thinh Nguyen [this message]
2024-08-07 14:30         ` Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240807004105.pea4z7oobw7n3qy6@synopsys.com \
    --to=thinh.nguyen@synopsys.com \
    --cc=Frank.li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®