From: Sunil V L <sunilvl@ventanamicro.com>
To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Sunil V L <sunilvl@ventanamicro.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH] serial: 8250_platform: Fix unused acpi_platform_serial_table warning
Date: Wed, 7 Aug 2024 11:58:39 +0530 [thread overview]
Message-ID: <20240807062839.1738705-1-sunilvl@ventanamicro.com> (raw)
The LKP reports below warning.
>> drivers/tty/serial/8250/8250_platform.c:271:36: warning: 'acpi_platform_serial_table' defined but not used [-Wunused-const-variable=]
271 | static const struct acpi_device_id acpi_platform_serial_table[] = {
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
This is because some architectures don't define either ACPI or
MODULE/MODULE_DEVICE_TABLE. So, keep acpi_platform_serial_table under
CONFIG_ACPI to fix the warning on such architectures.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407310047.PIoWlrZZ-lkp@intel.com/
Fixes: d9e5a0ce2f16 ("serial: 8250_platform: Enable generic 16550A platform devices")
Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
---
drivers/tty/serial/8250/8250_platform.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/tty/serial/8250/8250_platform.c b/drivers/tty/serial/8250/8250_platform.c
index bdfb16bed4f2..168e635002aa 100644
--- a/drivers/tty/serial/8250/8250_platform.c
+++ b/drivers/tty/serial/8250/8250_platform.c
@@ -268,11 +268,13 @@ static int serial8250_resume(struct platform_device *dev)
return 0;
}
+#ifdef CONFIG_ACPI
static const struct acpi_device_id acpi_platform_serial_table[] = {
{ "RSCV0003", 0 }, // RISC-V Generic 16550A UART
{ },
};
MODULE_DEVICE_TABLE(acpi, acpi_platform_serial_table);
+#endif
static struct platform_driver serial8250_isa_driver = {
.probe = serial8250_probe,
--
2.43.0
reply other threads:[~2024-08-07 6:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807062839.1738705-1-sunilvl@ventanamicro.com \
--to=sunilvl@ventanamicro.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®