From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 984011C9DD8 for ; Wed, 7 Aug 2024 08:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723020239; cv=none; b=sL0M236izXvjVZSt+CD80Gazre+XUQdXA57hSDoBJqIaRuBGdNVx5JfA6YQK0TFfhKi0NRHPJZzBuP/rVFEb1cIlOWxy59A0pmac8IKHDSBiH7SuaNnSJHmQt6/KhY8wXCZ1G3SPH8t4sg7Cyap+ypZRw1fBfOhlpLQLRizLzXY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723020239; c=relaxed/simple; bh=4BstarA/azTj0MQhXEHPNbE5+HYWrDilUXJZYFWQ+iw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=WtCmJ7GQlRL8Ki3IobwCjDPgxGlcu45QFf+RLju4TCd3FIgsZRWqvKP3qPzGD/2bpzyVgJKfI2tWisufFFDwn6kAlB5h0SOpTvD+6bt0/5rTp79+ei4QSi4+uZVcn6yn8GU6SoQtv8SkrhNl4BP1UXRG0CcvCAvXrGzSlOH6hpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=XztcIIQl; arc=none smtp.client-ip=209.85.210.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="XztcIIQl" Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-709485aca4bso692338a34.1 for ; Wed, 07 Aug 2024 01:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1723020236; x=1723625036; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=Iw7Tv+YETDv5W6d9wVYOGpd/7bHckBYfrgRk1yNks+I=; b=XztcIIQlQGTNQ7UKqlmdsSh/dnA6/N+kkIGkfZiNHHWE30rGNe0zAuAkBL5CiNooE8 7BEWeAxOU7mOL69uoo3/1cgnz/zduwOZ+9shcigCjSB+RBlyRsWcPcVJbRcffzkOs04p pMjQ/tMghE0E9ZcEDt98sfbecJnQ5GMvTAbOFeOk4EouMLTKknP68JwQhl9RnbtIEA1x VQc1Qyb/PNGlqycMK0T5mi4gnvh4q5rZOPsbqOr4bEe/pPuCaqVmmGCMNWOhw4xyNXdx uB/jnfpwNUew2p8iVy+r7OFrw3fdSLFuABW/1OpMEefmL7mXwFnWcZgOBL7B4WtKXMpr mHUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723020236; x=1723625036; h=references:in-reply-to:message-id:date:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Iw7Tv+YETDv5W6d9wVYOGpd/7bHckBYfrgRk1yNks+I=; b=ldlrq5WNufyFY/OP+OlYEt49C07wrvsw+dz4XbUfODKLq+8phBVICsq3YpC84Q4IhR IDTuqGFhvvfL8YxraaLUlLllU3WFJt0jaoAh6KNEXqKADfhFkG2Y0loH3rOdBe+y6IYk rB+W+jxkm3mf6rVQF3Y/higQs3At37JKLQFk3F6JOpZnojDyxhZVEJgff09Aj69/bCb/ cn+xFQ4dnMWLkbvNABvRWnn4g6llr9CFl7+WR3eaZe/cp0i5hUQ3Iygxfq5WEG1R9t9C xeXaXW16TV/NJhoGZdm/UTZxYyMJRWBZFOgAvvwPSaTu/bcQ63zrqofqAKEObF9Ri5Zr ptWw== X-Forwarded-Encrypted: i=1; AJvYcCXLnuk/7K/CnfMlenAUEZFdXeIgCCyOURthogPgGvcqfdgrE/02eijlDsi+cZ/aeq3r++4C14uJeTEuLpOM2F4BKSX2ijV4i9R8KuL/ X-Gm-Message-State: AOJu0YxyEvCdKfngH1CkPsBNAZ2zuFqYCaPBhb1P12LQQeMtIK383tnh Totvzx4m9JB6eUSSzAgTRhtyjWUukc5gtGFLWh5FQSMa87MrPxL0k/aHVzwQknw= X-Google-Smtp-Source: AGHT+IHGDJwgvu27ZoxkF/Iz1RMQROmHIKs8TmuQAxLdh09B6CWq3+c9Jjh5o5EFESeTZQUuMmrUsQ== X-Received: by 2002:a05:6358:418f:b0:1ac:660a:8a69 with SMTP id e5c5f4694b2df-1af3baf62a6mr2337848555d.18.1723020236454; Wed, 07 Aug 2024 01:43:56 -0700 (PDT) Received: from dev-mattc2.dev.purestorage.com ([208.88.159.128]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-7b7654bf852sm6742435a12.90.2024.08.07.01.43.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Aug 2024 01:43:55 -0700 (PDT) From: Matthew W Carlis To: helgaas@kernel.org Cc: alex.williamson@redhat.com, bhelgaas@google.com, davem@davemloft.net, david.abdurachmanov@gmail.com, edumazet@google.com, kuba@kernel.org, leon@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, lukas@wunner.de, macro@orcam.me.uk, mahesh@linux.ibm.com, mattc@purestorage.com, mika.westerberg@linux.intel.com, netdev@vger.kernel.org, npiggin@gmail.com, oohall@gmail.com, pabeni@redhat.com, pali@kernel.org, saeedm@nvidia.com, sr@denx.de, wilson@tuliptree.org Subject: PCI: Work around PCIe link training failures Date: Wed, 7 Aug 2024 02:43:48 -0600 Message-Id: <20240807084348.12304-1-mattc@purestorage.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240806193622.GA74589@bhelgaas> References: <20240806193622.GA74589@bhelgaas> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: On Tues, 06 Aug 2024 Bjorn Helgaas wrote: > it does seem like this series made wASMedia ASM2824 work better but > caused regressions elsewhere, so maybe we just need to accept that > ASM2824 is slightly broken and doesn't work as well as it should. One of my colleagues challenged me to provide a more concrete example where the change will cause problems. One such configuration would be not implementing the Power Controller Control in the Slot Capabilities Register. Then, Powering off the slot via out-of-band interfaces would result in the kernel forcing the DSP to Gen1 100% of the time as far as I can tell. The aspect of this force to Gen1 that is the most concerning to my team is that it isn't cleaned up even if we replaced the EP with some other EP. I was curious about the PCIe devices mentioned in the commit because I look at crazy malfunctioning devices too often so I pasted the following: "Delock Riser Card PCI Expres 41433" into Google. I'm not really a physical layer guy, but is it possible that the reported issue be due to signal integrity? I'm not sure if sending PCIe over a USB cable is "reliable". I've never worked with an ASMedia switch and don't have a reliable way to reproduce anything like the interaction between the two device at hand. As much as I hate to make the request my thinking is that the patch should be reverted until there is a solution that doesn't leave the link forced to Gen1 forever for every EP thereafter. - Matt