From: Peter Zijlstra <peterz@infradead.org>
To: James Clark <james.clark@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, Al Grant <al.grant@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] drivers/perf: arm_spe: Use perf_allow_kernel() for permissions
Date: Wed, 7 Aug 2024 13:15:20 +0200 [thread overview]
Message-ID: <20240807111520.GC37996@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20240807105441.2156738-1-james.clark@linaro.org>
On Wed, Aug 07, 2024 at 11:54:41AM +0100, James Clark wrote:
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index aa3450bdc227..4a69583e329a 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -417,6 +417,7 @@ static struct kmem_cache *perf_event_cache;
> * 2 - disallow kernel profiling for unpriv
> */
> int sysctl_perf_event_paranoid __read_mostly = 2;
> +EXPORT_SYMBOL_GPL(sysctl_perf_event_paranoid);
I'm never a fan of exporting variables. Perhaps create a helper function
that returns the value and use that where required?
That avoids modules getting the idea it would be okay to change this
valie themselves.
next prev parent reply other threads:[~2024-08-07 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 10:54 James Clark
2024-08-07 11:15 ` Peter Zijlstra [this message]
2024-08-07 11:20 ` James Clark
2024-08-07 12:00 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807111520.GC37996@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=al.grant@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jmorris@namei.org \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®