From: Markus Schneider-Pargmann <msp@baylibre.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Markus Schneider-Pargmann" <msp@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Ronald Wahl" <ronald.wahl@raritan.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Thomas Richard" <thomas.richard@bootlin.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Udit Kumar" <u-kumar1@ti.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: Vibhore Vardhan <vibhore@ti.com>,
Kevin Hilman <khilman@baylibre.com>, Dhruva Gole <d-gole@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org
Subject: [PATCH v2 4/5] serial: 8250: omap: Set wakeup capable, do not enable
Date: Wed, 7 Aug 2024 16:12:26 +0200 [thread overview]
Message-ID: <20240807141227.1093006-5-msp@baylibre.com> (raw)
In-Reply-To: <20240807141227.1093006-1-msp@baylibre.com>
The driver sets wakeup enable by default. But not all UARTs are meant to
be wakeup enabled. Change the default to be wakeup capable but not
enabled. The user can enable wakeup when needed.
Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
---
drivers/tty/serial/8250/8250_omap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_omap.c b/drivers/tty/serial/8250/8250_omap.c
index 01d430de9c64..7a6dfd40af9e 100644
--- a/drivers/tty/serial/8250/8250_omap.c
+++ b/drivers/tty/serial/8250/8250_omap.c
@@ -1529,7 +1529,7 @@ static int omap8250_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, priv);
- device_init_wakeup(&pdev->dev, true);
+ device_set_wakeup_capable(&pdev->dev, true);
pm_runtime_enable(&pdev->dev);
pm_runtime_use_autosuspend(&pdev->dev);
@@ -1628,7 +1628,7 @@ static void omap8250_remove(struct platform_device *pdev)
flush_work(&priv->qos_work);
pm_runtime_disable(&pdev->dev);
cpu_latency_qos_remove_request(&priv->pm_qos_request);
- device_init_wakeup(&pdev->dev, false);
+ device_set_wakeup_capable(&pdev->dev, false);
}
static int omap8250_prepare(struct device *dev)
--
2.45.2
next prev parent reply other threads:[~2024-08-07 14:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 14:12 [PATCH v2 0/5] serial: 8250: omap: Add am62 wakeup support Markus Schneider-Pargmann
2024-08-07 14:12 ` [PATCH v2 1/5] dt-bindings: serial: 8250_omap: Add wakeup-source property Markus Schneider-Pargmann
2024-08-07 16:31 ` Conor Dooley
2024-08-07 14:12 ` [PATCH v2 2/5] serial: 8250: omap: Remove unused wakeups_enabled Markus Schneider-Pargmann
2024-08-07 14:12 ` [PATCH v2 3/5] serial: 8250: omap: Cleanup on error in request_irq Markus Schneider-Pargmann
2024-08-07 14:12 ` Markus Schneider-Pargmann [this message]
2024-08-07 14:12 ` [PATCH v2 5/5] serial: 8250: omap: Parse DT wakeup-source proerty Markus Schneider-Pargmann
2024-08-07 18:55 ` [PATCH v2 0/5] serial: 8250: omap: Add am62 wakeup support Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807141227.1093006-5-msp@baylibre.com \
--to=msp@baylibre.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=d-gole@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ronald.wahl@raritan.com \
--cc=tglx@linutronix.de \
--cc=thomas.richard@bootlin.com \
--cc=tony@atomide.com \
--cc=u-kumar1@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vibhore@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®