From: Yihang Li <liyihang9@huawei.com>
To: <James.Bottomley@HansenPartnership.com>, <martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<prime.zeng@huawei.com>, <liyihang9@huawei.com>,
<linuxarm@huawei.com>
Subject: [PATCH] scsi: sd: Have scsi-ml retry START_STOP errors
Date: Thu, 8 Aug 2024 11:46:19 +0800 [thread overview]
Message-ID: <20240808034619.768289-1-liyihang9@huawei.com> (raw)
When sending START_STOP commands to resume scsi_device, it may be
interrupted by exception operations such as host reset or PCI FLR. Once
the command of START_STOP is failed, the runtime_status of scsi device
will be error and it is difficult for user to recover it.
So try more retries to increase robustness as the process of command
START_STOP.
Signed-off-by: Yihang Li <liyihang9@huawei.com>
---
drivers/scsi/sd.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 5cd88a8eea73..29f30407d713 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -4088,9 +4088,20 @@ static int sd_start_stop_device(struct scsi_disk *sdkp, int start)
{
unsigned char cmd[6] = { START_STOP }; /* START_VALID */
struct scsi_sense_hdr sshdr;
+ struct scsi_failure failure_defs[] = {
+ {
+ .allowed = 3,
+ .result = SCMD_FAILURE_RESULT_ANY,
+ },
+ {}
+ };
+ struct scsi_failures failures = {
+ .failure_definitions = failure_defs,
+ };
const struct scsi_exec_args exec_args = {
.sshdr = &sshdr,
.req_flags = BLK_MQ_REQ_PM,
+ .failures = &failures,
};
struct scsi_device *sdp = sdkp->device;
int res;
--
2.33.0
next reply other threads:[~2024-08-08 3:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 3:46 Yihang Li [this message]
2024-08-08 17:20 ` Bart Van Assche
2024-08-09 8:28 ` Yihang Li
2024-08-09 18:25 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808034619.768289-1-liyihang9@huawei.com \
--to=liyihang9@huawei.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=prime.zeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®