mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zijun Hu <zijun_hu@icloud.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 "Rafael J. Wysocki" <rafael@kernel.org>,
	 Davidlohr Bueso <dave@stgolabs.net>,
	 Jonathan Cameron <jonathan.cameron@huawei.com>,
	 Dave Jiang <dave.jiang@intel.com>,
	 Alison Schofield <alison.schofield@intel.com>,
	 Vishal Verma <vishal.l.verma@intel.com>,
	Ira Weiny <ira.weiny@intel.com>,
	 Dan Williams <dan.j.williams@intel.com>,
	 Takashi Sakamoto <o-takashi@sakamocchi.jp>,
	Timur Tabi <timur@kernel.org>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Cc: Zijun Hu <zijun_hu@icloud.com>,
	linux-kernel@vger.kernel.org,  linux-cxl@vger.kernel.org,
	linux1394-devel@lists.sourceforge.net,  netdev@vger.kernel.org,
	Zijun Hu <quic_zijuhu@quicinc.com>
Subject: [PATCH 4/5] firewire: core: Prevent device_find_child() from modifying caller's match data
Date: Sun, 11 Aug 2024 08:18:10 +0800	[thread overview]
Message-ID: <20240811-const_dfc_prepare-v1-4-d67cc416b3d3@quicinc.com> (raw)
In-Reply-To: <20240811-const_dfc_prepare-v1-0-d67cc416b3d3@quicinc.com>

From: Zijun Hu <quic_zijuhu@quicinc.com>

It does not make sense for lookup_existing_device() as match function
of device_find_child() to modify caller's match data, fixed by using
constify_device_find_child_helper() instead of device_find_child().

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 drivers/firewire/core-device.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c
index 00e9a13e6c45..04b150bc876d 100644
--- a/drivers/firewire/core-device.c
+++ b/drivers/firewire/core-device.c
@@ -1087,8 +1087,9 @@ static void fw_device_init(struct work_struct *work)
 		return;
 	}
 
-	revived_dev = device_find_child(card->device,
-					device, lookup_existing_device);
+	revived_dev = constify_device_find_child_helper(card->device,
+							device,
+							lookup_existing_device);
 	if (revived_dev) {
 		put_device(revived_dev);
 		fw_device_release(&device->device);

-- 
2.34.1


  parent reply	other threads:[~2024-08-11  0:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-11  0:18 [PATCH 0/5] driver " Zijun Hu
2024-08-11  0:18 ` [PATCH 1/5] driver core: Add simple parameter checks for APIs device_(for_each|find)_child() Zijun Hu
2024-08-13  9:44   ` Greg Kroah-Hartman
2024-08-13 10:00     ` quic_zijuhu
2024-08-13 10:19       ` Greg Kroah-Hartman
2024-08-11  0:18 ` [PATCH 2/5] driver core: Introduce an API constify_device_find_child_helper() Zijun Hu
2024-08-13  9:45   ` Greg Kroah-Hartman
2024-08-13 10:50     ` quic_zijuhu
2024-08-13 10:57       ` Greg Kroah-Hartman
2024-08-13 11:15         ` quic_zijuhu
2024-08-11  0:18 ` [PATCH 3/5] cxl/region: Prevent device_find_child() from modifying caller's match data Zijun Hu
2024-08-12 12:54   ` Przemek Kitszel
2024-08-12 15:32     ` Zijun Hu
2024-08-11  0:18 ` Zijun Hu [this message]
2024-08-11  0:18 ` [PATCH 5/5] net: qcom/emac: " Zijun Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240811-const_dfc_prepare-v1-4-d67cc416b3d3@quicinc.com \
    --to=zijun_hu@icloud.com \
    --cc=alison.schofield@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.jiang@intel.com \
    --cc=dave@stgolabs.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ira.weiny@intel.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=kuba@kernel.org \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=o-takashi@sakamocchi.jp \
    --cc=pabeni@redhat.com \
    --cc=quic_zijuhu@quicinc.com \
    --cc=rafael@kernel.org \
    --cc=timur@kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®