From: Igor Mammedov <imammedo@redhat.com>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Shiju Jose <shiju.jose@huawei.com>,
Dongjiu Geng <gengdongjiu1@gmail.com>,
linux-kernel@vger.kernel.org, qemu-arm@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [PATCH v6 07/10] docs: acpi_hest_ghes: fix documentation for CPER size
Date: Mon, 12 Aug 2024 13:59:19 +0200 [thread overview]
Message-ID: <20240812135919.1b4865c6@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <93ae03bd89b47731f6703dab5925ed2f7a9fd426.1723119423.git.mchehab+huawei@kernel.org>
On Thu, 8 Aug 2024 14:26:33 +0200
Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
> While the spec defines a CPER size of 4KiB for each record,
> currently it is set to 1KiB. Fix the documentation and add
> a pointer to the macro name there, as this may help to keep
> it updated.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Acked-by: Igor Mammedov <imammedo@redhat.com>
> ---
> docs/specs/acpi_hest_ghes.rst | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/docs/specs/acpi_hest_ghes.rst b/docs/specs/acpi_hest_ghes.rst
> index 68f1fbe0a4af..c3e9f8d9a702 100644
> --- a/docs/specs/acpi_hest_ghes.rst
> +++ b/docs/specs/acpi_hest_ghes.rst
> @@ -67,8 +67,10 @@ Design Details
> (3) The address registers table contains N Error Block Address entries
> and N Read Ack Register entries. The size for each entry is 8-byte.
> The Error Status Data Block table contains N Error Status Data Block
> - entries. The size for each entry is 4096(0x1000) bytes. The total size
> - for the "etc/hardware_errors" fw_cfg blob is (N * 8 * 2 + N * 4096) bytes.
> + entries. The size for each entry is defined at the source code as
> + ACPI_GHES_MAX_RAW_DATA_LENGTH (currently 1024 bytes). The total size
> + for the "etc/hardware_errors" fw_cfg blob is
> + (N * 8 * 2 + N * ACPI_GHES_MAX_RAW_DATA_LENGTH) bytes.
> N is the number of the kinds of hardware error sources.
>
> (4) QEMU generates the ACPI linker/loader script for the firmware. The
next prev parent reply other threads:[~2024-08-12 11:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1723119423.git.mchehab+huawei@kernel.org>
2024-08-08 12:26 ` [PATCH v6 01/10] acpi/generic_event_device: add an APEI error device Mauro Carvalho Chehab
2024-08-12 11:20 ` Igor Mammedov
2024-08-08 12:26 ` [PATCH v6 02/10] arm/virt: Wire up a GED error device for ACPI / GHES Mauro Carvalho Chehab
2024-08-12 11:27 ` Igor Mammedov
2024-08-08 12:26 ` [PATCH v6 03/10] acpi/ghes: Add support for GED error device Mauro Carvalho Chehab
2024-08-12 11:28 ` Igor Mammedov
2024-08-08 12:26 ` [PATCH v6 04/10] qapi/ghes-cper: add an interface to do generic CPER error injection Mauro Carvalho Chehab
2024-08-08 13:23 ` Markus Armbruster
2024-08-12 11:57 ` Igor Mammedov
2024-08-13 22:52 ` Mauro Carvalho Chehab
2024-08-08 12:26 ` [PATCH v6 05/10] acpi/ghes: rework the logic to handle HEST source ID Mauro Carvalho Chehab
2024-08-08 12:26 ` [PATCH v6 06/10] acpi/ghes: add support for generic error injection via QAPI Mauro Carvalho Chehab
2024-08-08 12:26 ` [PATCH v6 07/10] docs: acpi_hest_ghes: fix documentation for CPER size Mauro Carvalho Chehab
2024-08-12 11:59 ` Igor Mammedov [this message]
2024-08-08 12:26 ` [PATCH v6 08/10] scripts/ghes_inject: add a script to generate GHES error inject Mauro Carvalho Chehab
2024-08-08 13:21 ` Markus Armbruster
2024-08-08 12:26 ` [PATCH v6 09/10] target/arm: add an experimental mpidr arm cpu property object Mauro Carvalho Chehab
2024-08-12 12:02 ` Igor Mammedov
2024-08-08 12:26 ` [PATCH v6 10/10] scripts/arm_processor_error.py: retrieve mpidr if not filled Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812135919.1b4865c6@imammedo.users.ipa.redhat.com \
--to=imammedo@redhat.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=gengdongjiu1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shiju.jose@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®