From: Joe Damato <jdamato@fastly.com>
To: netdev@vger.kernel.org
Cc: Joe Damato <jdamato@fastly.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jiri Pirko <jiri@resnulli.us>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
linux-kernel@vger.kernel.org (open list)
Subject: [RFC net-next 1/6] netdevice: Add napi_affinity_no_change
Date: Mon, 12 Aug 2024 14:56:22 +0000 [thread overview]
Message-ID: <20240812145633.52911-2-jdamato@fastly.com> (raw)
In-Reply-To: <20240812145633.52911-1-jdamato@fastly.com>
Several drivers have their own, very similar, implementations of
determining if IRQ affinity has changed. Create napi_affinity_no_change
to centralize this logic in the core.
This will be used in following commits for various drivers to eliminate
duplicated code.
Signed-off-by: Joe Damato <jdamato@fastly.com>
---
include/linux/netdevice.h | 8 ++++++++
net/core/dev.c | 14 ++++++++++++++
2 files changed, 22 insertions(+)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 0ef3eaa23f4b..dc714a04b90a 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -464,6 +464,14 @@ enum rx_handler_result {
typedef enum rx_handler_result rx_handler_result_t;
typedef rx_handler_result_t rx_handler_func_t(struct sk_buff **pskb);
+/**
+ * napi_affinity_no_change - determine if CPU affinity changed
+ * @irq: the IRQ whose affinity may have changed
+ *
+ * Return true if the CPU affinity has NOT changed, false otherwise.
+ */
+bool napi_affinity_no_change(unsigned int irq);
+
void __napi_schedule(struct napi_struct *n);
void __napi_schedule_irqoff(struct napi_struct *n);
diff --git a/net/core/dev.c b/net/core/dev.c
index 751d9b70e6ad..9c56ad49490c 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -89,6 +89,7 @@
#include <linux/errno.h>
#include <linux/interrupt.h>
#include <linux/if_ether.h>
+#include <linux/irq.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
#include <linux/ethtool.h>
@@ -6210,6 +6211,19 @@ void __napi_schedule_irqoff(struct napi_struct *n)
}
EXPORT_SYMBOL(__napi_schedule_irqoff);
+bool napi_affinity_no_change(unsigned int irq)
+{
+ int cpu_curr = smp_processor_id();
+ const struct cpumask *aff_mask;
+
+ aff_mask = irq_get_effective_affinity_mask(irq);
+ if (unlikely(!aff_mask))
+ return true;
+
+ return cpumask_test_cpu(cpu_curr, aff_mask);
+}
+EXPORT_SYMBOL(napi_affinity_no_change);
+
bool napi_complete_done(struct napi_struct *n, int work_done)
{
unsigned long flags, val, new, timeout = 0;
--
2.25.1
next prev parent reply other threads:[~2024-08-12 14:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 14:56 [RFC net-next 0/6] Cleanup IRQ affinity checks in several drivers Joe Damato
2024-08-12 14:56 ` Joe Damato [this message]
2024-08-12 20:23 ` [RFC net-next 1/6] netdevice: Add napi_affinity_no_change Stanislav Fomichev
2024-08-12 21:08 ` Joe Damato
2024-08-12 22:36 ` Stanislav Fomichev
2024-08-13 9:11 ` Joe Damato
2024-08-13 10:03 ` Joe Damato
2024-08-13 13:05 ` Simon Horman
2024-08-12 14:56 ` [RFC net-next 2/6] mlx5: Use napi_affinity_no_change Joe Damato
2024-08-12 14:56 ` [RFC net-next 3/6] gve: " Joe Damato
2024-08-13 18:55 ` Shailend Chand
2024-08-13 21:44 ` Joe Damato
2024-08-13 21:50 ` Shailend Chand
2024-08-12 14:56 ` [RFC net-next 4/6] i40e: " Joe Damato
2024-08-12 14:56 ` [RFC net-next 5/6] iavf: " Joe Damato
2024-08-12 14:56 ` [RFC net-next 6/6] mlx4: " Joe Damato
2024-08-14 0:17 ` [RFC net-next 0/6] Cleanup IRQ affinity checks in several drivers Jakub Kicinski
2024-08-14 7:14 ` Joe Damato
2024-08-14 12:12 ` Joe Damato
2024-08-14 15:09 ` Jakub Kicinski
2024-08-14 15:19 ` Joe Damato
2024-08-14 16:03 ` Shay Drori
2024-08-14 18:01 ` Joe Damato
2024-08-15 0:20 ` Jakub Kicinski
2024-08-15 10:22 ` Joe Damato
2024-08-20 6:40 ` Shay Drori
2024-08-20 8:33 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812145633.52911-2-jdamato@fastly.com \
--to=jdamato@fastly.com \
--cc=bigeasy@linutronix.de \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®