From: Abhinav Jain <jain.abhinav177@gmail.com>
To: kuniyu@amazon.com
Cc: davem@davemloft.net, edumazet@google.com,
jain.abhinav177@gmail.com, javier.carrasco.cruz@gmail.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, shuah@kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH net] selftest: af_unix: Fix kselftest compilation warnings
Date: Tue, 13 Aug 2024 00:45:30 +0530 [thread overview]
Message-ID: <20240812191530.1093038-1-jain.abhinav177@gmail.com> (raw)
In-Reply-To: <20240812183944.59844-1-kuniyu@amazon.com>
On Mon, 12 Aug 2024 11:39:44 -0700, Kuniyuki Iwashima wrote:
> Fixes: tag is needed here (no space between SOB tag)
Thank you, I have added it in v2 here:
> I don't remember why I defined expected_buf as (void *), but more simple
> fix would be the following ?
>
> ---8<---
> diff --git a/tools/testing/selftests/net/af_unix/msg_oob.c b/tools/testing/selftests/net/af_unix/msg_oob.c
> index 16d0c172eaeb..535eb2c3d7d1 100644
> --- a/tools/testing/selftests/net/af_unix/msg_oob.c
> +++ b/tools/testing/selftests/net/af_unix/msg_oob.c
> @@ -209,7 +209,7 @@ static void __sendpair(struct __test_metadata *_metadata,
>
> static void __recvpair(struct __test_metadata *_metadata,
> FIXTURE_DATA(msg_oob) *self,
> - const void *expected_buf, int expected_len,
> + const char *expected_buf, int expected_len,
> int buf_len, int flags)
> {
> int i, ret[2], recv_errno[2], expected_errno = 0;
> ---8<---
Yes, I completely missed that. I have sent a v2, please review:
lore.kernel.org/all/20240812191122.1092806-1-jain.abhinav177@gmail.com
prev parent reply other threads:[~2024-08-12 19:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-10 13:40 Abhinav Jain
2024-08-12 18:39 ` Kuniyuki Iwashima
2024-08-12 19:15 ` Abhinav Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812191530.1093038-1-jain.abhinav177@gmail.com \
--to=jain.abhinav177@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®