From: Changhuang Liang <changhuang.liang@starfivetech.com>
To: mike.rudenko@gmail.com
Cc: christophe.jaillet@wanadoo.fr, dave.stevenson@raspberrypi.com,
jacopo@jmondi.org, laurent.pinchart@ideasonboard.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
tomm.merciai@gmail.com, changhuang.liang@starfivetech.com
Subject: [PATCH 4/4] media: i2c: ov4689: Implement 2x2 binning
Date: Tue, 13 Aug 2024 05:44:43 -0700 [thread overview]
Message-ID: <20240813124443.446703-1-changhuang.liang@starfivetech.com> (raw)
In-Reply-To: <20240616202433.227895-5-mike.rudenko@gmail.com>
Hi, Mikhail
Thanks for your patch.
>
> Implement 2x2 binning support. Compute best binning mode (none or 2x2)
> from pad crop and pad format in ov4689_set_fmt. Use output frame size
> instead of analogue crop to compute control ranges and BLC anchors.
>
> Also move ov4689_hts_min and ov4689_update_ctrl_ranges, since they are
> now also called from ov4689_set_fmt. Update frame timings to
> accommodate the requirements of binning mode and avoid visual
> artefacts. Additionally, report 2x2 binned mode in addition to
> non-binned one in ov4689_enum_frame_sizes.
>
> Signed-off-by: Mikhail Rudenko <mike.rudenko@gmail.com>
Tested-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
> drivers/media/i2c/ov4689.c | 179 ++++++++++++++++++++++++-------------
> 1 file changed, 117 insertions(+), 62 deletions(-)
>
> diff --git a/drivers/media/i2c/ov4689.c b/drivers/media/i2c/ov4689.c
> index c4c7c462672a..1499fbe88b76 100644
> --- a/drivers/media/i2c/ov4689.c
> +++ b/drivers/media/i2c/ov4689.c
> @@ -114,7 +114,7 @@
> * Minimum working vertical blanking value. Found experimentally at
> * minimum HTS values.
> */
Regards,
Changhuang
next prev parent reply other threads:[~2024-08-13 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-16 20:24 [PATCH 0/4] Omnivision OV4689 cropping and binning Mikhail Rudenko
2024-06-16 20:24 ` [PATCH 1/4] media: i2c: ov4689: Configurable analogue crop Mikhail Rudenko
2024-06-16 20:24 ` [PATCH 2/4] media: i2c: ov4689: Eliminate struct ov4689_mode Mikhail Rudenko
2024-06-16 20:24 ` [PATCH 3/4] media: i2c: ov4689: Refactor ov4689_s_stream Mikhail Rudenko
2024-06-16 20:24 ` [PATCH 4/4] media: i2c: ov4689: Implement 2x2 binning Mikhail Rudenko
2024-08-13 12:44 ` Changhuang Liang [this message]
2024-08-13 18:48 ` Mikhail Rudenko
2024-08-14 23:01 ` [PATCH 0/4] Omnivision OV4689 cropping and binning Mikhail Rudenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813124443.446703-1-changhuang.liang@starfivetech.com \
--to=changhuang.liang@starfivetech.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dave.stevenson@raspberrypi.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mike.rudenko@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®