From: Daniel Almeida <daniel.almeida@collabora.com>
To: liviu.dudau@arm.com, steven.price@arm.com,
carsten.haitzler@arm.com, boris.brezillon@collabora.com,
robh@kernel.org, faith.ekstrand@collabora.com
Cc: Daniel Almeida <daniel.almeida@collabora.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/5] drm: panthor: add debugfs knob to dump successful jobs
Date: Tue, 13 Aug 2024 18:05:47 -0300 [thread overview]
Message-ID: <20240813210555.607641-6-daniel.almeida@collabora.com> (raw)
In-Reply-To: <20240813210555.607641-1-daniel.almeida@collabora.com>
It can be advantageous for userspace to have access to successful jobs.
Allow this as an opt-in through a debugfs file.
Note that the devcoredump infrastructure will discard new dumps if a
previous dump hasn't been read. A future patch will add support for
multi-job dumps which will work around this limitation.
Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com>
---
drivers/gpu/drm/panthor/panthor_sched.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c
index afd644c7d9f1..ea2696c1075a 100644
--- a/drivers/gpu/drm/panthor/panthor_sched.c
+++ b/drivers/gpu/drm/panthor/panthor_sched.c
@@ -10,6 +10,7 @@
#include <linux/build_bug.h>
#include <linux/clk.h>
+#include <linux/debugfs.h>
#include <linux/delay.h>
#include <linux/dma-mapping.h>
#include <linux/dma-resv.h>
@@ -317,6 +318,9 @@ struct panthor_scheduler {
*/
struct list_head stopped_groups;
} reset;
+
+ /** @dump_successful_jobs: whether to dump successful jobs through coredumpv */
+ bool dump_successful_jobs;
};
/**
@@ -2946,6 +2950,16 @@ queue_run_job(struct drm_sched_job *sched_job)
queue->iface.input->extract = queue->iface.output->extract;
queue->iface.input->insert = job->ringbuf.end;
+ if (sched->dump_successful_jobs) {
+ struct panthor_core_dump_args core_dump_args = {
+ .ptdev = ptdev,
+ .group_vm = job->group->vm,
+ .group = job->group,
+ };
+
+ panthor_core_dump(&core_dump_args);
+ }
+
if (group->csg_id < 0) {
/* If the queue is blocked, we want to keep the timeout running, so we
* can detect unbounded waits and kill the group when that happens.
@@ -3609,5 +3623,8 @@ void panthor_sched_debugfs_init(struct drm_minor *minor)
struct panthor_device *ptdev =
container_of(minor->dev, struct panthor_device, base);
struct panthor_scheduler *sched = ptdev->scheduler;
+
+ debugfs_create_bool("dump_successful_jobs", 0644, minor->debugfs_root,
+ &sched->dump_successful_jobs);
}
#endif /* CONFIG_DEBUG_FS */
--
2.45.2
next prev parent reply other threads:[~2024-08-13 21:06 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 22:50 [RFC PATCH] drm: panthor: add dev_coredumpv support Daniel Almeida
2024-07-11 0:01 ` Danilo Krummrich
2024-07-15 9:03 ` Daniel Vetter
2024-07-15 17:05 ` Daniel Almeida
2024-07-16 9:25 ` Daniel Vetter
2024-07-25 19:35 ` Lyude Paul
2024-07-26 13:40 ` Daniel Vetter
2024-07-29 18:34 ` Lyude Paul
2024-07-30 8:29 ` Daniel Vetter
2024-07-11 16:57 ` Liviu Dudau
2024-07-11 18:40 ` Daniel Almeida
2024-07-12 9:46 ` Steven Price
2024-07-12 14:35 ` Daniel Almeida
2024-07-12 14:53 ` Danilo Krummrich
2024-07-12 15:13 ` Daniel Almeida
2024-07-12 15:32 ` Danilo Krummrich
2024-07-13 0:48 ` Dave Airlie
2024-07-13 1:00 ` Daniel Almeida
2024-07-13 8:17 ` Miguel Ojeda
2024-07-15 9:12 ` Steven Price
2024-07-23 9:44 ` Alice Ryhl
2024-07-23 16:06 ` Boris Brezillon
2024-07-23 17:23 ` Daniel Almeida
2024-07-24 8:59 ` Steven Price
2024-07-24 10:44 ` Boris Brezillon
2024-07-24 12:37 ` Steven Price
2024-07-24 13:15 ` Rob Herring
2024-07-24 13:54 ` Steven Price
2024-07-24 14:27 ` Daniel Almeida
2024-07-24 14:35 ` Steven Price
2024-07-24 14:38 ` Miguel Ojeda
2024-07-25 11:42 ` Carsten Haitzler
2024-07-25 11:45 ` Carsten Haitzler
2024-07-23 9:53 ` Alice Ryhl
2024-07-23 13:41 ` Daniel Almeida
2024-07-23 13:45 ` Alice Ryhl
2024-08-13 21:05 ` [PATCH v2 0/5] Panthor devcoredump support Daniel Almeida
2024-08-13 21:05 ` [PATCH v2 1/5] drm: panthor: expose some fw information through the query ioctl Daniel Almeida
2024-08-14 13:44 ` Boris Brezillon
2024-08-13 21:05 ` [PATCH v2 2/5] drm: panthor: add devcoredump support Daniel Almeida
2024-08-15 6:01 ` kernel test robot
2024-08-13 21:05 ` [PATCH v2 3/5] drm: panthor: add debugfs support in panthor_sched Daniel Almeida
2024-08-13 21:05 ` Daniel Almeida [this message]
2024-08-13 21:05 ` [PATCH v2 5/5] drm: panthor: allow dumping multiple jobs Daniel Almeida
2024-08-21 14:37 ` [PATCH v2 RESEND 0/5] Panthor devcoredump support Daniel Almeida
2024-08-21 14:37 ` [PATCH v2 RESEND 1/5] drm: panthor: expose some fw information through the query ioctl Daniel Almeida
2024-08-22 12:26 ` Adrian Larumbe
2024-08-23 13:15 ` Boris Brezillon
2024-09-20 12:57 ` Mihail Atanassov
2024-08-21 14:37 ` [PATCH v2 RESEND 2/5] drm: panthor: add devcoredump support Daniel Almeida
2024-08-22 12:27 ` Adrian Larumbe
2024-08-23 14:46 ` Boris Brezillon
2024-08-21 14:37 ` [PATCH v2 RESEND 3/5] drm: panthor: add debugfs support in panthor_sched Daniel Almeida
2024-08-21 14:37 ` [PATCH v2 RESEND 4/5] drm: panthor: add debugfs knob to dump successful jobs Daniel Almeida
2024-08-22 12:36 ` Adrian Larumbe
2024-08-21 14:37 ` [PATCH v2 RESEND 5/5] drm: panthor: allow dumping multiple jobs Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240813210555.607641-6-daniel.almeida@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=carsten.haitzler@arm.com \
--cc=faith.ekstrand@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®