From: Ricardo Ribalda <ribalda@chromium.org>
To: Stanimir Varbanov <stanimir.k.varbanov@gmail.com>,
Vikash Garodia <quic_vgarodia@quicinc.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH v7 02/10] media: venus: Refactor struct hfi_uncompressed_plane_info
Date: Wed, 14 Aug 2024 11:39:22 +0000 [thread overview]
Message-ID: <20240814-cocci-flexarray-v7-2-8a1cc09ae6c4@chromium.org> (raw)
In-Reply-To: <20240814-cocci-flexarray-v7-0-8a1cc09ae6c4@chromium.org>
This field is never used, but if we remove it we would change the size
of the struct and can lead to behavior change. Stay on the safe side by
replacing the single element array with a single element field.
This fixes the following cocci warning:
drivers/media/platform/qcom/venus/hfi_helper.h:1003:43-60: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Acked-by: Vikash Garodia <quic_vgarodia@quicinc.com>
---
drivers/media/platform/qcom/venus/hfi_helper.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/venus/hfi_helper.h b/drivers/media/platform/qcom/venus/hfi_helper.h
index e4c05d62cfc7..5e91f3f6984d 100644
--- a/drivers/media/platform/qcom/venus/hfi_helper.h
+++ b/drivers/media/platform/qcom/venus/hfi_helper.h
@@ -1005,7 +1005,7 @@ struct hfi_uncompressed_plane_constraints {
struct hfi_uncompressed_plane_info {
u32 format;
u32 num_planes;
- struct hfi_uncompressed_plane_constraints plane_constraints[1];
+ struct hfi_uncompressed_plane_constraints plane_constraints;
};
struct hfi_uncompressed_format_supported {
--
2.46.0.76.ge559c4bf1a-goog
next prev parent reply other threads:[~2024-08-14 11:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 11:39 [PATCH v7 00/10] media: Fix the last set of coccinelle warnings Ricardo Ribalda
2024-08-14 11:39 ` [PATCH v7 01/10] media: venus: Use flex array for hfi_session_release_buffer_pkt Ricardo Ribalda
2024-08-26 7:12 ` Hans Verkuil
2024-08-14 11:39 ` Ricardo Ribalda [this message]
2024-08-14 11:39 ` [PATCH v7 03/10] media: venus: Refactor struct hfi_session_get_property_pkt Ricardo Ribalda
2024-08-14 11:39 ` [PATCH v7 04/10] media: venus: Refactor struct hfi_uncompressed_format_supported Ricardo Ribalda
2024-08-14 11:39 ` [PATCH v7 05/10] media: venus: Refactor hfi_session_empty_buffer_uncompressed_plane0_pkt Ricardo Ribalda
2024-08-14 11:39 ` [PATCH v7 06/10] media: venus: Refactor hfi_session_empty_buffer_compressed_pkt Ricardo Ribalda
2024-08-14 11:39 ` [PATCH v7 07/10] media: venus: Refactor hfi_sys_get_property_pkt Ricardo Ribalda
2024-08-14 11:39 ` [PATCH v7 08/10] media: venus: Refactor hfi_session_fill_buffer_pkt Ricardo Ribalda
2024-08-14 11:39 ` [PATCH v7 09/10] media: venus: Refactor hfi_buffer_alloc_mode_supported Ricardo Ribalda
2024-08-14 11:39 ` [PATCH v7 10/10] media: venus: Convert one-element-arrays to flex-arrays Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814-cocci-flexarray-v7-2-8a1cc09ae6c4@chromium.org \
--to=ribalda@chromium.org \
--cc=bryan.odonoghue@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=quic_vgarodia@quicinc.com \
--cc=stanimir.k.varbanov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®