From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.thorsis.com (mail.thorsis.com [217.92.40.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B5CE17D8A6; Thu, 15 Aug 2024 07:58:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.92.40.78 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723708698; cv=none; b=ht+xgLnW5YtzZvSsHEKVdJYO+4IYKx+6HHLfXw05G3uPsGcmb9k1YLp0QLgEcT/LLTxtKGPSvpR8RjYdubaSsA8vH7svb4/oYAy2r5b8rFJ7KA9KsX/Gykcb+n3qLrZj+JbX4JoPr0lS1BqeO7QF9xRlsvZSG9cMH39hm+ZwewM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723708698; c=relaxed/simple; bh=kFlUg8RnShHlE4ohDvhQ7L+98DC89mlWaW/bJcrzUok=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hD84eIK3smcM7n4WEUOZOxuN9eJenRlGG3XF+TDiBS6BVgee6ZKCjH+pgTvLv9cFZMpEK1X5JyvzmDiSwnDdYxqqSxc/q0oINtE5lvjXrkcMGXmcuRdKSm+wkysztMnrwNPCIh7ZmW+kjNqDnB0Z79MGmfxointMqUcpalasq0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=thorsis.com; spf=pass smtp.mailfrom=thorsis.com; dkim=pass (2048-bit key) header.d=thorsis.com header.i=@thorsis.com header.b=ovyDsBP4; arc=none smtp.client-ip=217.92.40.78 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=thorsis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=thorsis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=thorsis.com header.i=@thorsis.com header.b="ovyDsBP4" Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 686C714803C9; Thu, 15 Aug 2024 09:58:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1723708685; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=ZUabmVKLYg7ovcA0kdMSO2roCBz3aftZYmz2ejKvnhY=; b=ovyDsBP4k0tSQ2KsZmM8q+8v1ccQWoMMrRHwdDVJTEUVkFFVbOBvIFagD2CoxbbrYRs6Gn BAFBwA7WjPHA/bEN4Qc9zhdLpn8zinqkHg1blxpd5Dz7PW5WXFDztHZZjXaDZaAgPJmVCe PJx/ajEvplC/qH+Py172nKp2MVFTVfQMs4YwyqXfpbnnP7+oAtT22Y5f1/NGyaElUfKvE+ QNFt3vRqdpSy7ZlZALdjHohIJTLQTl36aGTe4oyeV39ziusWLLkiiy1pSj2X2BxTJ9CcAf qvFYbVVlOO8iGVwCUbywUop2F4vC7S1aRroZz9C7VA89T/S8/GOrgdfSbp1N3w== Date: Thu, 15 Aug 2024 09:57:56 +0200 From: Alexander Dahl To: Andrei Simion Cc: claudiu.beznea@tuxon.dev, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, peda@axentia.se, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, cristian.birsan@microchip.com, linux-leds@vger.kernel.org Subject: Re: [PATCH 5/5] ARM: dts: microchip: Rename LED sub nodes name Message-ID: <20240815-ambush-cavalier-80adf0260765@thorsis.com> Mail-Followup-To: Andrei Simion , claudiu.beznea@tuxon.dev, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, peda@axentia.se, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, cristian.birsan@microchip.com, linux-leds@vger.kernel.org References: <20240814122633.198562-1-andrei.simion@microchip.com> <20240814122633.198562-6-andrei.simion@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240814122633.198562-6-andrei.simion@microchip.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 Hello Andrei, Am Wed, Aug 14, 2024 at 03:26:33PM +0300 schrieb Andrei Simion: > dtbs_check warnings: > leds: 'd[0-9]', 'ds[0-9]' do not match any of the regexes: > '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' > leds: 'red', 'green', 'blue' do not match any of regexes: > '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+' > > Rename the led sub nodes according to devicetree > specification and leds-gpio.yaml. > > Signed-off-by: Andrei Simion > --- > Split the bloadted patch into small patches on topics > based on comments: > https://lore.kernel.org/linux-arm-kernel/89f51615-0dee-4ab0-ab72-e3c057fee1e7@tuxon.dev/ > --- > arch/arm/boot/dts/microchip/aks-cdu.dts | 8 ++++---- > arch/arm/boot/dts/microchip/animeo_ip.dts | 8 ++++---- > arch/arm/boot/dts/microchip/at91-sam9x60ek.dts | 6 +++--- > arch/arm/boot/dts/microchip/at91rm9200ek.dts | 6 +++--- > arch/arm/boot/dts/microchip/at91sam9260ek.dts | 4 ++-- > arch/arm/boot/dts/microchip/at91sam9261ek.dts | 6 +++--- > arch/arm/boot/dts/microchip/at91sam9263ek.dts | 4 ++-- > arch/arm/boot/dts/microchip/at91sam9g20ek.dts | 4 ++-- > 8 files changed, 23 insertions(+), 23 deletions(-) > > diff --git a/arch/arm/boot/dts/microchip/aks-cdu.dts b/arch/arm/boot/dts/microchip/aks-cdu.dts > index 52e166c8a365..95a0639c5579 100644 > --- a/arch/arm/boot/dts/microchip/aks-cdu.dts > +++ b/arch/arm/boot/dts/microchip/aks-cdu.dts > @@ -98,23 +98,23 @@ rootfs@500000 { > leds { > compatible = "gpio-leds"; > > - red { > + led-red { > gpios = <&pioC 10 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "none"; > }; > > - green { > + led-green { > gpios = <&pioA 5 GPIO_ACTIVE_LOW>; > linux,default-trigger = "none"; > default-state = "on"; > }; > > - yellow { > + led-yellow { > gpios = <&pioB 20 GPIO_ACTIVE_LOW>; > linux,default-trigger = "none"; > }; > > - blue { > + led-blue { > gpios = <&pioB 21 GPIO_ACTIVE_LOW>; > linux,default-trigger = "none"; > }; As reported with <20240730-rambling-helping-2f03f5ddee6a@thorsis.com> already, this will probably change sysfs paths and thus might break userspace depending on those paths. Did you consider adding a label to avoid this? (Added linux-leds to Cc.) Greets Alex > diff --git a/arch/arm/boot/dts/microchip/animeo_ip.dts b/arch/arm/boot/dts/microchip/animeo_ip.dts > index 911c8d9ee013..52ac840bcd35 100644 > --- a/arch/arm/boot/dts/microchip/animeo_ip.dts > +++ b/arch/arm/boot/dts/microchip/animeo_ip.dts > @@ -146,23 +146,23 @@ ohci: usb@500000 { > leds { > compatible = "gpio-leds"; > > - power_green { > + led-power-green { > label = "power_green"; > gpios = <&pioC 17 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > }; > > - power_red { > + led-power-red { > label = "power_red"; > gpios = <&pioA 2 GPIO_ACTIVE_HIGH>; > }; > > - tx_green { > + led-tx-green { > label = "tx_green"; > gpios = <&pioC 19 GPIO_ACTIVE_HIGH>; > }; > > - tx_red { > + led-tx-red { > label = "tx_red"; > gpios = <&pioC 18 GPIO_ACTIVE_HIGH>; > }; > diff --git a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts > index b9a21f9f9a6d..da31b07d6828 100644 > --- a/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts > +++ b/arch/arm/boot/dts/microchip/at91-sam9x60ek.dts > @@ -53,17 +53,17 @@ leds { > pinctrl-0 = <&pinctrl_gpio_leds>; > status = "okay"; /* Conflict with pwm0. */ > > - red { > + led-red { > label = "red"; > gpios = <&pioB 11 GPIO_ACTIVE_HIGH>; > }; > > - green { > + led-green { > label = "green"; > gpios = <&pioB 12 GPIO_ACTIVE_HIGH>; > }; > > - blue { > + led-blue { > label = "blue"; > gpios = <&pioB 13 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > diff --git a/arch/arm/boot/dts/microchip/at91rm9200ek.dts b/arch/arm/boot/dts/microchip/at91rm9200ek.dts > index 3089912dd6be..641d443e6ca9 100644 > --- a/arch/arm/boot/dts/microchip/at91rm9200ek.dts > +++ b/arch/arm/boot/dts/microchip/at91rm9200ek.dts > @@ -127,19 +127,19 @@ root@350000 { > leds { > compatible = "gpio-leds"; > > - ds2 { > + led-ds2 { > label = "green"; > gpios = <&pioB 0 GPIO_ACTIVE_LOW>; > linux,default-trigger = "mmc0"; > }; > > - ds4 { > + led-ds4 { > label = "yellow"; > gpios = <&pioB 1 GPIO_ACTIVE_LOW>; > linux,default-trigger = "heartbeat"; > }; > > - ds6 { > + led-ds6 { > label = "red"; > gpios = <&pioB 2 GPIO_ACTIVE_LOW>; > }; > diff --git a/arch/arm/boot/dts/microchip/at91sam9260ek.dts b/arch/arm/boot/dts/microchip/at91sam9260ek.dts > index ed259e2cb853..4933971d0585 100644 > --- a/arch/arm/boot/dts/microchip/at91sam9260ek.dts > +++ b/arch/arm/boot/dts/microchip/at91sam9260ek.dts > @@ -174,13 +174,13 @@ eeprom@50 { > leds { > compatible = "gpio-leds"; > > - ds1 { > + led-ds1 { > label = "ds1"; > gpios = <&pioA 9 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > }; > > - ds5 { > + led-ds5 { > label = "ds5"; > gpios = <&pioA 6 GPIO_ACTIVE_LOW>; > }; > diff --git a/arch/arm/boot/dts/microchip/at91sam9261ek.dts b/arch/arm/boot/dts/microchip/at91sam9261ek.dts > index 4d9269cc5f32..9c44177db714 100644 > --- a/arch/arm/boot/dts/microchip/at91sam9261ek.dts > +++ b/arch/arm/boot/dts/microchip/at91sam9261ek.dts > @@ -192,19 +192,19 @@ watchdog@fffffd40 { > leds { > compatible = "gpio-leds"; > > - ds8 { > + led-ds8 { > label = "ds8"; > gpios = <&pioA 13 GPIO_ACTIVE_LOW>; > linux,default-trigger = "none"; > }; > > - ds7 { > + led-ds7 { > label = "ds7"; > gpios = <&pioA 14 GPIO_ACTIVE_LOW>; > linux,default-trigger = "nand-disk"; > }; > > - ds1 { > + led-ds1 { > label = "ds1"; > gpios = <&pioA 23 GPIO_ACTIVE_LOW>; > linux,default-trigger = "heartbeat"; > diff --git a/arch/arm/boot/dts/microchip/at91sam9263ek.dts b/arch/arm/boot/dts/microchip/at91sam9263ek.dts > index a8ea36db4c04..cf5434f9449d 100644 > --- a/arch/arm/boot/dts/microchip/at91sam9263ek.dts > +++ b/arch/arm/boot/dts/microchip/at91sam9263ek.dts > @@ -219,13 +219,13 @@ &pioA 21 GPIO_ACTIVE_HIGH > leds { > compatible = "gpio-leds"; > > - d3 { > + led-d3 { > label = "d3"; > gpios = <&pioB 7 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > }; > > - d2 { > + led-d2 { > label = "d2"; > gpios = <&pioC 29 GPIO_ACTIVE_LOW>; > linux,default-trigger = "nand-disk"; > diff --git a/arch/arm/boot/dts/microchip/at91sam9g20ek.dts b/arch/arm/boot/dts/microchip/at91sam9g20ek.dts > index 6de7a7cd3c07..1e62fd371ddb 100644 > --- a/arch/arm/boot/dts/microchip/at91sam9g20ek.dts > +++ b/arch/arm/boot/dts/microchip/at91sam9g20ek.dts > @@ -14,13 +14,13 @@ / { > leds { > compatible = "gpio-leds"; > > - ds1 { > + led-ds1 { > label = "ds1"; > gpios = <&pioA 9 GPIO_ACTIVE_HIGH>; > linux,default-trigger = "heartbeat"; > }; > > - ds5 { > + led-ds5 { > label = "ds5"; > gpios = <&pioA 6 GPIO_ACTIVE_LOW>; > }; > -- > 2.34.1 > >