From: Tree Davies <tdavies@darkphysics.net>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Tree Davies <tdavies@darkphysics.net>
Subject: [PATCH 6/6] Staging: rtl8192e: Rename variable CmdID_WritePortUchar
Date: Tue, 20 Aug 2024 20:08:56 -0700 [thread overview]
Message-ID: <20240821030856.57423-7-tdavies@darkphysics.net> (raw)
In-Reply-To: <20240821030856.57423-1-tdavies@darkphysics.net>
Rename variable CmdID_WritePortUchar to cmd_id_write_port_uchar
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
index c49dd8094c7c..0e8ca8bef00d 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c
@@ -624,7 +624,7 @@ static u8 _rtl92e_phy_switch_channel_step(struct net_device *dev, u8 channel,
rtl92e_writew(dev, CurrentCmd->Para1,
CurrentCmd->Para2);
break;
- case CmdID_WritePortUchar:
+ case cmd_id_write_port_uchar:
rtl92e_writeb(dev, CurrentCmd->Para1,
CurrentCmd->Para2);
break;
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index 0850ae0015d0..fe81cf9aa862 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -158,7 +158,7 @@ enum sw_chnl_cmd_id {
cmd_id_bbreg_write10,
cmd_id_write_port_ulong,
cmd_id_write_port_ushort,
- CmdID_WritePortUchar,
+ cmd_id_write_port_uchar,
CmdID_RF_WriteReg,
};
--
2.30.2
prev parent reply other threads:[~2024-08-21 3:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 3:08 [PATCH 0/6] Staging: rtl8192e: Style guide variable renames Tree Davies
2024-08-21 3:08 ` [PATCH 1/6] Staging: rtl8192e: Rename variable CmdID_End Tree Davies
2024-08-21 3:08 ` [PATCH 2/6] Staging: rtl8192e: Rename variable CmdID_SetTxPowerLevel Tree Davies
2024-08-21 3:08 ` [PATCH 3/6] Staging: rtl8192e: Rename variable CmdID_BBRegWrite10 Tree Davies
2024-08-21 3:08 ` [PATCH 4/6] Staging: rtl8192e: Rename variable CmdID_WritePortUlong Tree Davies
2024-08-21 12:41 ` Dan Carpenter
2024-08-21 3:08 ` [PATCH 5/6] Staging: rtl8192e: Rename variable CmdID_WritePortUshort Tree Davies
2024-08-21 3:08 ` Tree Davies [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821030856.57423-7-tdavies@darkphysics.net \
--to=tdavies@darkphysics.net \
--cc=anjan@momi.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®