From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org,
Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Subject: [PATCHSET 0/4] perf annotate-data: Update data-type profiling quality (v2)
Date: Wed, 21 Aug 2024 16:26:24 -0700 [thread overview]
Message-ID: <20240821232628.353177-1-namhyung@kernel.org> (raw)
Hello,
This is continuation of data type profiling series to improve its quality.
I've also found some more bugs and room for improvements.
Acutally it depends on the a couple of fixes I sent out yesterday.
But as they will be merged to perf-tools-next, I omitted them here.
There's no dramatic improvements at this moment, but I handled some
corner cases which makes instruction tracking more flexible. One
change is when it accesses (stores) a stack slot for the first time.
As it doesn't save anything there yet, it doesn't come with a type
info. In that case it can try to process the instruction with
update_insn_state() and get the type information again.
Another update is when compiler generates the debug info inaccurately.
A variable information is there but in some cases it was using another
register to access the data and it resulted in no type information.
So I tracked the (direct) register move and update the type info for
the source registre as well.
The code is available at 'perf/data-profile-update-v2' branch in
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Thanks,
Namhyung
Namhyung Kim (4):
perf dwarf-aux: Handle bitfield members from pointer access
perf annotate-data: Update debug messages
perf annotate-data: Update stack slot for the store
perf annotate-data: Copy back variable types after move
tools/perf/arch/x86/annotate/instructions.c | 8 ++
tools/perf/util/annotate-data.c | 105 +++++++++++++++++---
tools/perf/util/annotate-data.h | 1 +
tools/perf/util/dwarf-aux.c | 11 +-
4 files changed, 109 insertions(+), 16 deletions(-)
--
2.46.0.184.g6999bdac58-goog
next reply other threads:[~2024-08-21 23:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 23:26 Namhyung Kim [this message]
2024-08-21 23:26 ` [PATCH 1/4] perf dwarf-aux: Handle bitfield members from pointer access Namhyung Kim
2024-08-21 23:26 ` [PATCH 2/4] perf annotate-data: Update debug messages Namhyung Kim
2024-08-21 23:26 ` [PATCH 3/4] perf annotate-data: Update stack slot for the store Namhyung Kim
2024-08-21 23:26 ` [PATCH 4/4] perf annotate-data: Copy back variable types after move Namhyung Kim
2024-08-22 20:54 ` [PATCHSET 0/4] perf annotate-data: Update data-type profiling quality (v2) Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821232628.353177-1-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=atrajeev@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®