From: liujinbao1 <jinbaoliu365@gmail.com>
To: xiang@kernel.org
Cc: chao@kernel.org, linux-erofs@lists.ozlabs.org,
linux-kernel@vger.kernel.org, liujinbao1 <liujinbao1@xiaomi.com>
Subject: [PATCH] Prevent entering an infinite loop when i is 0
Date: Thu, 22 Aug 2024 14:27:49 +0800 [thread overview]
Message-ID: <20240822062749.4012080-1-jinbaoliu365@gmail.com> (raw)
From: liujinbao1 <liujinbao1@xiaomi.com>
When i=0 and err is not equal to 0,
the while(-1) loop will enter into an
infinite loop. This patch avoids this issue.
---
fs/erofs/decompressor.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/erofs/decompressor.c b/fs/erofs/decompressor.c
index c2253b6a5416..1b2b8cc7911c 100644
--- a/fs/erofs/decompressor.c
+++ b/fs/erofs/decompressor.c
@@ -539,6 +539,8 @@ int __init z_erofs_init_decompressor(void)
for (i = 0; i < Z_EROFS_COMPRESSION_MAX; ++i) {
err = z_erofs_decomp[i] ? z_erofs_decomp[i]->init() : 0;
if (err) {
+ if (!i)
+ return err;
while (--i)
if (z_erofs_decomp[i])
z_erofs_decomp[i]->exit();
--
2.25.1
next reply other threads:[~2024-08-22 6:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 6:27 liujinbao1 [this message]
2024-08-22 6:42 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240822062749.4012080-1-jinbaoliu365@gmail.com \
--to=jinbaoliu365@gmail.com \
--cc=chao@kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liujinbao1@xiaomi.com \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®