mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Charles Han <hanchunchao@inspur.com>
Cc: neil.armstrong@linaro.org, quic_jesszhan@quicinc.com,
	mripard@kernel.org, security@kernel.org,
	linux-kernel@vger.kernel.org, liuyanming@ieisystem.com
Subject: Re: [PATCH] drm/panel/hx83102: fix null pointer dereference in hx83102_get_modes
Date: Thu, 22 Aug 2024 07:45:51 +0800	[thread overview]
Message-ID: <2024082229-unretired-dallying-775d@gregkh> (raw)
In-Reply-To: <20240821095039.15282-1-hanchunchao@inspur.com>

On Wed, Aug 21, 2024 at 05:50:39PM +0800, Charles Han wrote:
> From: hanchunchao <hanchunchao@inspur.com>

Nit, this should be your name, not your email alias here, like you have
it on your "From" line.

> In hx83102_get_modes(), the return value of drm_mode_duplicate() is
> assigned to mode, which will lead to a possible NULL pointer dereference
> on failure of drm_mode_duplicate(). Add a check to avoid npd.
> 
> Signed-off-by: hanchunchao <hanchunchao@inspur.com>

Same here.

What commit id does this fix?  Shouldn't you also cc: stable to get it
backported?

And there's no need to cc: security@kernel.org, as this is a public
issue and you have a patch for it.

thanks,

greg k-h

  reply	other threads:[~2024-08-21 23:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21  9:50 Charles Han
2024-08-21 23:45 ` Greg KH [this message]
2024-08-22  2:21 ` kernel test robot
2024-08-22  3:24 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024082229-unretired-dallying-775d@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=hanchunchao@inspur.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuyanming@ieisystem.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_jesszhan@quicinc.com \
    --cc=security@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®