mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Md Sadre Alam <quic_mdalam@quicinc.com>
Cc: vkoul@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, andersson@kernel.org,
	konradybcio@kernel.org, thara.gopinath@gmail.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	gustavoars@kernel.org, u.kleine-koenig@pengutronix.de,
	kees@kernel.org, agross@kernel.org,
	linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org, quic_srichara@quicinc.com,
	quic_varada@quicinc.com, quic_utiwari@quicinc.com
Subject: Re: [PATCH v2 01/16] dt-bindings: dma: qcom,bam: Add bam pipe lock
Date: Fri, 23 Aug 2024 21:09:58 +0530	[thread overview]
Message-ID: <20240823153958.vk4naz34vgkqzhrb@thinkpad> (raw)
In-Reply-To: <20240815085725.2740390-2-quic_mdalam@quicinc.com>

On Thu, Aug 15, 2024 at 02:27:10PM +0530, Md Sadre Alam wrote:
> BAM having pipe locking mechanism. The Lock and Un-Lock bit
> should be set on CMD descriptor only. Upon encountering a
> descriptor with Lock bit set, the BAM will lock all other
> pipes not related to the current pipe group, and keep
> handling the current pipe only until it sees the Un-Lock
> set.
> 
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---
> 
> Change in [v2]
> 
> * Added initial support for dt-binding
> 
> Change in [v1]
> 
> * This patch was not included in [v1]
> 
>  Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> index 3ad0d9b1fbc5..91cc2942aa62 100644
> --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> @@ -77,6 +77,12 @@ properties:
>        Indicates that the bam is powered up by a remote processor but must be
>        initialized by the local processor.
>  
> +  qcom,bam_pipe_lock:
> +    type: boolean
> +    description:
> +      Indicates that the bam pipe needs locking or not based on client driver
> +      sending the LOCK or UNLOK bit set on command descriptor.
> +

This looks like a pure driver implementation and doesn't belong to the DT at
all. Why can't you add a logic in the driver to use the lock based on some
detection mechanism?

- Mani

>    reg:
>      maxItems: 1
>  
> @@ -92,6 +98,8 @@ anyOf:
>        - qcom,powered-remotely
>    - required:
>        - qcom,controlled-remotely
> +  - required:
> +      - qcom,bam_pipe_lock
>    - required:
>        - clocks
>        - clock-names
> -- 
> 2.34.1
> 
> 

-- 
மணிவண்ணன் சதாசிவம்

  parent reply	other threads:[~2024-08-23 15:40 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15  8:57 [PATCH v2 00/16] Add cmd descriptor support Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 01/16] dt-bindings: dma: qcom,bam: Add bam pipe lock Md Sadre Alam
2024-08-16 15:53   ` Bjorn Andersson
2024-08-21  4:54     ` Md Sadre Alam
2024-08-17  9:08   ` Krzysztof Kozlowski
2024-08-21 16:34     ` Md Sadre Alam
2024-08-22  6:27       ` Krzysztof Kozlowski
2024-08-22 11:45         ` Md Sadre Alam
2024-08-23  9:07           ` Krzysztof Kozlowski
2024-08-24  7:07             ` Md Sadre Alam
2024-08-23 15:39   ` Manivannan Sadhasivam [this message]
2024-08-24  7:04     ` Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 02/16] dmaengine: qcom: bam_dma: add bam_pipe_lock dt property Md Sadre Alam
2024-08-17  9:08   ` Krzysztof Kozlowski
2024-08-21 16:36     ` Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 03/16] dmaengine: qcom: bam_dma: add LOCK & UNLOCK flag support Md Sadre Alam
2024-08-16 16:22   ` Bjorn Andersson
2024-08-21 16:31     ` Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 04/16] crypto: qce - Add support for crypto address read Md Sadre Alam
2024-08-17  9:10   ` Krzysztof Kozlowski
2024-08-21 16:40     ` Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 05/16] crypto: qce - Add bam dma support for crypto register r/w Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 06/16] crypto: qce - Convert register r/w for skcipher via BAM/DMA Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 07/16] crypto: qce - Convert register r/w for sha " Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 08/16] crypto: qce - Convert register r/w for aead " Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 09/16] crypto: qce - Add LOCK and UNLOCK flag support Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 10/16] crypto: qce - Add support for lock aquire,lock release api Md Sadre Alam
2024-08-16 16:38   ` Bjorn Andersson
2024-08-21  5:14     ` Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 11/16] crypto: qce - Add support for lock/unlock in skcipher Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 12/16] crypto: qce - Add support for lock/unlock in sha Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 13/16] crypto: qce - Add support for lock/unlock in aead Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 14/16] arm64: dts: qcom: ipq9574: enable bam pipe locking/unlocking Md Sadre Alam
2024-08-16 16:40   ` Bjorn Andersson
2024-08-21  5:16     ` Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 15/16] arm64: dts: qcom: ipq8074: " Md Sadre Alam
2024-08-15  8:57 ` [PATCH v2 16/16] arm64: dts: qcom: ipq6018: " Md Sadre Alam
2024-08-15 13:08 ` [PATCH v2 00/16] Add cmd descriptor support Caleb Connolly
2024-08-16 12:03   ` Md Sadre Alam
2024-08-16 15:45     ` Bjorn Andersson
2024-09-06  7:06       ` Md Sadre Alam
2024-08-16 16:01 ` Bjorn Andersson
2024-08-21  4:57   ` Md Sadre Alam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240823153958.vk4naz34vgkqzhrb@thinkpad \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=gustavoars@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=kees@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_mdalam@quicinc.com \
    --cc=quic_srichara@quicinc.com \
    --cc=quic_utiwari@quicinc.com \
    --cc=quic_varada@quicinc.com \
    --cc=robh@kernel.org \
    --cc=thara.gopinath@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®