From: Christian Brauner <brauner@kernel.org>
To: Jan Kara <jack@suse.cz>
Cc: Mateusz Guzik <mjguzik@gmail.com>,
viro@zeniv.linux.org.uk, jlayton@kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: drop one lock trip in evict()
Date: Tue, 27 Aug 2024 09:59:11 +0200 [thread overview]
Message-ID: <20240827-panzerglas-wohngebiet-85bb20c2729d@brauner> (raw)
In-Reply-To: <20240826202746.ipovnb5hfom7jkmb@quack3>
On Mon, Aug 26, 2024 at 10:27:46PM GMT, Jan Kara wrote:
> On Tue 13-08-24 16:36:26, Mateusz Guzik wrote:
> > Most commonly neither I_LRU_ISOLATING nor I_SYNC are set, but the stock
> > kernel takes a back-to-back relock trip to check for them.
> >
> > It probably can be avoided altogether, but for now massage things back
> > to just one lock acquire.
> >
> > Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
>
> Back from vacation so not sure if this is still actual but the patch looks
> good to me. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
It's all still in vfs.misc so we can still add RvBs.
So go ahead and ack whatever you want to ack. :)
prev parent reply other threads:[~2024-08-27 7:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 14:36 Mateusz Guzik
2024-08-14 1:33 ` Zhihao Cheng
2024-08-14 12:04 ` Jeff Layton
2024-08-14 12:43 ` Christian Brauner
2024-08-26 20:27 ` Jan Kara
2024-08-27 7:59 ` Christian Brauner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827-panzerglas-wohngebiet-85bb20c2729d@brauner \
--to=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjguzik@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®