From: Yuntao Wang <yuntao.wang@linux.dev>
To: linux-kernel@vger.kernel.org, x86@kernel.org
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Nadav Amit <nadav.amit@gmail.com>,
Yuntao Wang <yuntao.wang@linux.dev>
Subject: [PATCH] x86/mm/tlb: Correct the comments in flush_tlb_mm_range() and arch_tlbbatch_flush()
Date: Wed, 28 Aug 2024 10:07:41 +0800 [thread overview]
Message-ID: <20240828020741.99869-1-yuntao.wang@linux.dev> (raw)
Commit 4c1ba3923e6c ("x86/mm/tlb: Unify flush_tlb_func_local() and
flush_tlb_func_remote()") unified flush_tlb_func_local() and
flush_tlb_func_remote() into flush_tlb_func(). However, in commit
4ce94eabac16 ("x86/mm/tlb: Flush remote and local TLBs concurrently"),
the newly introduced comments still refer to flush_tlb_func_local() when
they should use flush_tlb_func().
Correct these comments.
Signed-off-by: Yuntao Wang <yuntao.wang@linux.dev>
---
arch/x86/mm/tlb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
index 44ac64f3a047..8b874ec90536 100644
--- a/arch/x86/mm/tlb.c
+++ b/arch/x86/mm/tlb.c
@@ -1021,7 +1021,7 @@ void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start,
/*
* flush_tlb_multi() is not optimized for the common case in which only
* a local TLB flush is needed. Optimize this use-case by calling
- * flush_tlb_func_local() directly in this case.
+ * flush_tlb_func() directly in this case.
*/
if (cpumask_any_but(mm_cpumask(mm), cpu) < nr_cpu_ids) {
flush_tlb_multi(mm_cpumask(mm), info);
@@ -1254,7 +1254,7 @@ void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch)
/*
* flush_tlb_multi() is not optimized for the common case in which only
* a local TLB flush is needed. Optimize this use-case by calling
- * flush_tlb_func_local() directly in this case.
+ * flush_tlb_func() directly in this case.
*/
if (cpumask_any_but(&batch->cpumask, cpu) < nr_cpu_ids) {
flush_tlb_multi(&batch->cpumask, info);
--
2.46.0
reply other threads:[~2024-08-28 2:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828020741.99869-1-yuntao.wang@linux.dev \
--to=yuntao.wang@linux.dev \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=nadav.amit@gmail.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®