From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: davem@davemloft.net,
Pantelis Antoniou <pantelis.antoniou@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
Herve Codina <herve.codina@bootlin.com>,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH net-next 0/6] net: ethernet: fs_enet: Cleanup and phylink conversion
Date: Wed, 28 Aug 2024 11:50:56 +0200 [thread overview]
Message-ID: <20240828095103.132625-1-maxime.chevallier@bootlin.com> (raw)
This series aims at improving the fs_enet code and port it's PHY
handling from direct phylib access to using phylink instead.
Although this driver is quite old, there are still some users out there,
running an upstream kernel. The development I'm doing is on an MPC885
device, which uses fs_enet, as well as a MPC866-based device.
The main motivation for that work is to eventually support ethernet interfaces
that have more than one PHY attached to the MAC upstream, for which
phylink might be a pre-requisite. That work isn't submitted yet, and the
final solution might not even require phylink.
Regardless, I do believe that this series is relevant, as it does some
cleanup to the driver, and having it use phylink brings some nice
improvements as it simplifies the DT parsing, fixed-link handling and
removes code in that driver that predates even phylib itself.
The series is structured in the following way :
- Patches 1 and 2 are cosmetic changes. The former converts the source
to SPDX, while the latter has fs_enet-main.c pass checkpatch. Patch 2 is
really not mandatory in this series, and I understand that this isn't
the easiest or most pleasant patch to review. OTOH, this allows
getting a clean checkpatch output for the main part of the driver.
- Patches 3, 4 and 5 drop some leftovers from back when the driver didn't
use phylib, and brings the use of phylib macros.
- Patch 6 is the actual phylink port, which also cleans the bits of code
that become irrelevant when using phylink.
Testing was done on an MPC866 and MPC885, any test on other platforms
that use fs_enet are more than welcome.
Thanks,
Maxime
Maxime Chevallier (6):
net: ethernet: fs_enet: convert to SPDX
net: ethernet: fs_enet: cosmetic cleanups
net: ethernet: fs_enet: drop the .adjust_link custom fs_ops
net: ethernet: fs_enet: drop unused phy_info and mii_if_info
net: ethernet: fs_enet: fcc: use macros for speed and duplex values
net: ethernet: fs_enet: phylink conversion
.../net/ethernet/freescale/fs_enet/Kconfig | 2 +-
.../ethernet/freescale/fs_enet/fs_enet-main.c | 421 ++++++++----------
.../net/ethernet/freescale/fs_enet/fs_enet.h | 24 +-
.../net/ethernet/freescale/fs_enet/mac-fcc.c | 16 +-
.../net/ethernet/freescale/fs_enet/mac-fec.c | 14 +-
.../net/ethernet/freescale/fs_enet/mac-scc.c | 10 +-
.../ethernet/freescale/fs_enet/mii-bitbang.c | 5 +-
.../net/ethernet/freescale/fs_enet/mii-fec.c | 5 +-
8 files changed, 209 insertions(+), 288 deletions(-)
--
2.45.2
next reply other threads:[~2024-08-28 9:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 9:50 Maxime Chevallier [this message]
2024-08-28 9:50 ` [PATCH net-next 1/6] net: ethernet: fs_enet: convert to SPDX Maxime Chevallier
2024-08-28 10:12 ` Christophe Leroy
2024-08-28 9:50 ` [PATCH net-next 2/6] net: ethernet: fs_enet: cosmetic cleanups Maxime Chevallier
2024-08-28 10:16 ` Christophe Leroy
2024-08-28 9:50 ` [PATCH net-next 3/6] net: ethernet: fs_enet: drop the .adjust_link custom fs_ops Maxime Chevallier
2024-08-28 10:18 ` Christophe Leroy
2024-08-28 9:51 ` [PATCH net-next 4/6] net: ethernet: fs_enet: drop unused phy_info and mii_if_info Maxime Chevallier
2024-08-28 10:25 ` Christophe Leroy
2024-08-28 9:51 ` [PATCH net-next 5/6] net: ethernet: fs_enet: fcc: use macros for speed and duplex values Maxime Chevallier
2024-08-28 10:27 ` Christophe Leroy
2024-08-28 9:51 ` [PATCH net-next 6/6] net: ethernet: fs_enet: phylink conversion Maxime Chevallier
2024-08-28 10:38 ` Russell King (Oracle)
2024-08-28 11:44 ` Maxime Chevallier
2024-08-28 13:54 ` Russell King (Oracle)
2024-08-28 14:31 ` Maxime Chevallier
2024-08-28 16:32 ` Simon Horman
2024-08-29 8:46 ` Maxime Chevallier
2024-08-28 10:10 ` [PATCH net-next 0/6] net: ethernet: fs_enet: Cleanup and " Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240828095103.132625-1-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pantelis.antoniou@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®