mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joshua Hahn <joshua.hahnjy@gmail.com>
To: tj@kernel.org
Cc: JoshuaHahnjoshua.hahn6@gmail.com, cgroups@vger.kernel.org,
	hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, lizefan.x@bytedance.com,
	mkoutny@suse.com, shuah@kernel.org
Subject: Re: [PATCH 1/2] Tracking cgroup-level niced CPU time
Date: Thu, 29 Aug 2024 12:26:36 -0700	[thread overview]
Message-ID: <20240829192636.1054186-1-joshua.hahnjy@gmail.com> (raw)
In-Reply-To: <ZszHM_UV24aSWTC8@slm.duckdns.org>

Hello, thank you for reviewing the patch.

> > Cgroup-level CPU statistics currently include time spent on
> > user/system processes, but do not include niced CPU time (despite
> > already being tracked). This patch exposes niced CPU time to the
> > userspace, allowing users to get a better understanding of their
> > hardware limits and can facilitate better load-balancing.
>
> You aren't talking about the in-kernel scheduler's load balancer, right? If
> so, can you please update the description? This is a bit too confusing for a
> commit message for a kernel commit.

Thank you for pointing this out -- I'll edit the commit message to the
following in a v2:

Cgroup-level CPU statistics currently include time spent on
user/system processes, but do not include niced CPU time (despite
already being tracked). This patch exposes niced CPU time to the
userspace, allowing users to get a better understanding of their
hardware limits and can facilitate more informed workload distribution.

Thanks,
Joshua

  reply	other threads:[~2024-08-29 19:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-23 20:05 [PATCH 0/2] Exposing nice CPU usage to userspace Joshua
2024-08-23 20:05 ` [PATCH 1/2] Tracking cgroup-level niced CPU time Joshua
2024-08-26 18:19   ` Tejun Heo
2024-08-29 19:26     ` Joshua Hahn [this message]
2024-08-23 20:05 ` [PATCH 2/2] Selftests for niced CPU statistics Joshua
2024-08-26 11:59 ` [PATCH 0/2] Exposing nice CPU usage to userspace Michal Koutný
2024-08-26 16:13   ` Joshua Hahn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240829192636.1054186-1-joshua.hahnjy@gmail.com \
    --to=joshua.hahnjy@gmail.com \
    --cc=JoshuaHahnjoshua.hahn6@gmail.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=lizefan.x@bytedance.com \
    --cc=mkoutny@suse.com \
    --cc=shuah@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®