Re: [PATCH 6.6 000/341] 6.6.48-rc1 review

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Aug 27, 2024 at 10:47:53AM -0700, Florian Fainelli wrote:
> On 8/27/24 07:33, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 6.6.48 release.
> > There are 341 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Thu, 29 Aug 2024 14:37:36 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> > 	https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.48-rc1.gz
> > or in the git tree and branch at:
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Same problem as with the 6.1-rc, perf fails to build with:
> 
> In file included from ./util/header.h:10,
>                  from pmu-events/pmu-events.c:9:
> ../include/linux/bitmap.h: In function 'bitmap_zero':
> ../include/linux/bitmap.h:28:34: warning: implicit declaration of function
> 'ALIGN' [-Wimplicit-function-declaration]
>    28 | #define bitmap_size(nbits)      (ALIGN(nbits, BITS_PER_LONG) /
> BITS_PER_BYTE)
>       |                                  ^~~~~
> ../include/linux/bitmap.h:35:32: note: in expansion of macro 'bitmap_size'
>    35 |                 memset(dst, 0, bitmap_size(nbits));
>       |                                ^~~~~~~~~~~
>   LD /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/pmu-events/pmu-events-in.o
>   LINK
> /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/perf
> /local/stbopt_p/toolchains_303/stbgcc-12.3-1.0/bin/../lib/gcc/arm-unknown-linux-gnueabihf/12.3.0/../../../../arm-unknown-linux-gnueabihf/bin/ld: /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/perf-in.o:
> in function `record__mmap_read_evlist':
> builtin-record.c:(.text+0x13578): undefined reference to `ALIGN'
> /local/stbopt_p/toolchains_303/stbgcc-12.3-1.0/bin/../lib/gcc/arm-unknown-linux-gnueabihf/12.3.0/../../../../arm-unknown-linux-gnueabihf/bin/ld: /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/perf-in.o:
> in function `record__init_thread_masks_spec.constprop.0':
> builtin-record.c:(.text+0x13b10): undefined reference to `ALIGN'
> /local/stbopt_p/toolchains_303/stbgcc-12.3-1.0/bin/../lib/gcc/arm-unknown-linux-gnueabihf/12.3.0/../../../../arm-unknown-linux-gnueabihf/bin/ld:
> builtin-record.c:(.text+0x13b68): undefined reference to `ALIGN'
> /local/stbopt_p/toolchains_303/stbgcc-12.3-1.0/bin/../lib/gcc/arm-unknown-linux-gnueabihf/12.3.0/../../../../arm-unknown-linux-gnueabihf/bin/ld:
> builtin-record.c:(.text+0x13b9c): undefined reference to `ALIGN'
> /local/stbopt_p/toolchains_303/stbgcc-12.3-1.0/bin/../lib/gcc/arm-unknown-linux-gnueabihf/12.3.0/../../../../arm-unknown-linux-gnueabihf/bin/ld:
> builtin-record.c:(.text+0x13bd8): undefined reference to `ALIGN'
> /local/stbopt_p/toolchains_303/stbgcc-12.3-1.0/bin/../lib/gcc/arm-unknown-linux-gnueabihf/12.3.0/../../../../arm-unknown-linux-gnueabihf/bin/ld: /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/perf-in.o:builtin-record.c:(.text+0x13c14):
> more undefined references to `ALIGN' follow
> collect2: error: ld returned 1 exit status
> make[4]: *** [Makefile.perf:672: /local/users/fainelli/buildroot/output/arm/build/linux-custom/tools/perf/perf]
> Error 1
> make[3]: *** [Makefile.perf:242: sub-make] Error 2
> make[2]: *** [Makefile:70: all] Error 2
> make[1]: *** [package/pkg-generic.mk:294:
> /local/users/fainelli/buildroot/output/arm/build/linux-tools/.stamp_built]
> Error 2
> make: *** [Makefile:29: _all] Error 2

I think I've fixed this up now, but wow, I can't build perf at all for
6.6.y or 6.1.y.  So this might have been broken for a while?  Hopefully
people are just using perf from the latest kernel release anyway...

thanks,

greg k-h