mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Charles Han <hanchunchao@inspur.com>
Cc: broonie@kernel.org, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: intel: Add check devm_kasprintf() returned value
Date: Fri, 30 Aug 2024 12:10:04 +0300	[thread overview]
Message-ID: <20240830091004.GW1532424@black.fi.intel.com> (raw)
In-Reply-To: <20240830074106.8744-1-hanchunchao@inspur.com>

On Fri, Aug 30, 2024 at 03:41:06PM +0800, Charles Han wrote:
> intel_spi_populate_chip() use devm_kasprintf() to set pdata->name.
> This can return a NULL pointer on failure but this returned value
> is not checked.
> 
> Fixes: e58db3bcd93b ("spi: intel: Add default partition and name to the second chip")
> Signed-off-by: Charles Han <hanchunchao@inspur.com>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

  reply	other threads:[~2024-08-30  9:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-30  7:41 Charles Han
2024-08-30  9:10 ` Mika Westerberg [this message]
2024-08-30 16:46 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240830091004.GW1532424@black.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=hanchunchao@inspur.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®