From: Julian Sun <sunjunchao2870@gmail.com>
To: sunjunchao2870@gmail.com
Cc: brauner@kernel.org, chandan.babu@oracle.com, djwong@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org,
syzbot+296b1c84b9cbf306e5a0@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [iomap?] [xfs?] WARNING in iomap_write_begin
Date: Fri, 30 Aug 2024 19:31:30 +0800 [thread overview]
Message-ID: <20240830113130.165574-1-sunjunchao2870@gmail.com> (raw)
In-Reply-To: <df7fc9c1863f353091cfcb84f04e365aa4609bab.camel@gmail.com>
The patch passed test locally, and the patch in the link
appears to be messed up. Please retest.
#syz test: upstream ee9a43b7cfe2
diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
index 72c981e3dc92..6216c31aa3cc 100644
--- a/fs/xfs/xfs_iomap.c
+++ b/fs/xfs/xfs_iomap.c
@@ -1162,6 +1162,9 @@ xfs_buffered_write_iomap_begin(
if (error)
goto out_unlock;
+ /* Get extent info that may updated by xfs_bmapi_reserve_delalloc() */
+ xfs_iext_lookup_extent(ip, &ip->i_df, offset_fsb, &icur, &imap);
+
/*
* Flag newly allocated delalloc blocks with IOMAP_F_NEW so we punch
* them out if the write happens to fail.
next prev parent reply other threads:[~2024-08-30 11:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 8:14 syzbot
2024-08-27 8:54 ` Julian Sun
2024-08-27 10:13 ` Christoph Hellwig
2024-08-27 11:13 ` Julian Sun
2024-08-27 11:37 ` Christoph Hellwig
2024-08-27 11:40 ` Aleksandr Nogikh
2024-08-27 11:56 ` Julian Sun
2024-08-27 12:38 ` syzbot
2024-08-30 9:48 ` Julian Sun
2024-08-30 10:19 ` syzbot
2024-08-30 11:31 ` Julian Sun [this message]
2024-08-30 12:04 ` syzbot
2024-09-02 5:04 ` Julian Sun
2024-09-02 5:28 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830113130.165574-1-sunjunchao2870@gmail.com \
--to=sunjunchao2870@gmail.com \
--cc=brauner@kernel.org \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=syzbot+296b1c84b9cbf306e5a0@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®