From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: broonie@kernel.org, adhemerval.zanella@linaro.org,
linux-kernel@vger.kernel.org
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: [PATCH] selftests: vDSO: quash clang omitted parameter warning in getrandom test
Date: Fri, 30 Aug 2024 17:23:52 +0200 [thread overview]
Message-ID: <20240830152429.490640-1-Jason@zx2c4.com> (raw)
In-Reply-To: <ZtHjejGdhZnZu4WQ@zx2c4.com>
When building with clang, there's this warning:
vdso_test_getrandom.c:145:40: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
145 | static void *test_vdso_getrandom(void *)
| ^
vdso_test_getrandom.c:155:40: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
155 | static void *test_libc_getrandom(void *)
| ^
vdso_test_getrandom.c:165:43: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
165 | static void *test_syscall_getrandom(void *)
Add the named ctx parameter to quash it.
Reported-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
This will go in random.git alongside the stack of other fixes to this
area.
tools/testing/selftests/vDSO/vdso_test_getrandom.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/vDSO/vdso_test_getrandom.c b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
index 351daeb649c8..8866b65a4605 100644
--- a/tools/testing/selftests/vDSO/vdso_test_getrandom.c
+++ b/tools/testing/selftests/vDSO/vdso_test_getrandom.c
@@ -143,7 +143,7 @@ static ssize_t vgetrandom(void *buf, size_t len, unsigned long flags)
enum { TRIALS = 25000000, THREADS = 256 };
-static void *test_vdso_getrandom(void *)
+static void *test_vdso_getrandom(void *ctx)
{
for (size_t i = 0; i < TRIALS; ++i) {
unsigned int val;
@@ -153,7 +153,7 @@ static void *test_vdso_getrandom(void *)
return NULL;
}
-static void *test_libc_getrandom(void *)
+static void *test_libc_getrandom(void *ctx)
{
for (size_t i = 0; i < TRIALS; ++i) {
unsigned int val;
@@ -163,7 +163,7 @@ static void *test_libc_getrandom(void *)
return NULL;
}
-static void *test_syscall_getrandom(void *)
+static void *test_syscall_getrandom(void *ctx)
{
for (size_t i = 0; i < TRIALS; ++i) {
unsigned int val;
--
2.46.0
next prev parent reply other threads:[~2024-08-30 15:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 20:17 [PATCH v2] aarch64: vdso: Wire up getrandom() vDSO implementation Adhemerval Zanella
2024-08-29 20:46 ` Jason A. Donenfeld
2024-08-30 11:46 ` Will Deacon
2024-08-30 12:04 ` Jason A. Donenfeld
2024-08-30 15:05 ` Mark Brown
2024-08-30 12:28 ` Adhemerval Zanella Netto
2024-09-02 13:11 ` Jason A. Donenfeld
2024-09-02 13:19 ` Christophe Leroy
2024-09-02 13:25 ` Jason A. Donenfeld
2024-09-02 13:47 ` Adhemerval Zanella Netto
2024-09-02 15:10 ` Will Deacon
2024-08-30 14:11 ` Ard Biesheuvel
2024-08-30 17:38 ` Adhemerval Zanella Netto
2024-08-30 15:19 ` Mark Brown
2024-08-30 15:21 ` Jason A. Donenfeld
2024-08-30 15:23 ` Jason A. Donenfeld [this message]
2024-08-30 15:29 ` [PATCH] selftests: vDSO: quash clang omitted parameter warning in getrandom test Mark Brown
2024-08-30 16:18 ` [PATCH v2] aarch64: vdso: Wire up getrandom() vDSO implementation kernel test robot
2024-08-31 1:56 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830152429.490640-1-Jason@zx2c4.com \
--to=jason@zx2c4.com \
--cc=adhemerval.zanella@linaro.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®