From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Diogo Jahchan Koike <djahchankoike@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
syzbot+ec369e6d58e210135f71@syzkaller.appspotmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch net-next v5] ethtool: pse-pd: move pse validation into set
Date: Fri, 30 Aug 2024 18:27:18 +0200 [thread overview]
Message-ID: <20240830182718.6ed8d8e2@device-28.home> (raw)
In-Reply-To: <20240829184830.5861-1-djahchankoike@gmail.com>
Hi Diogo,
On Thu, 29 Aug 2024 15:48:27 -0300
Diogo Jahchan Koike <djahchankoike@gmail.com> wrote:
> Move validation into set, removing .set_validate operation as its current
> implementation holds the rtnl lock for acquiring the PHY device, defeating
> the intended purpose of checking before grabbing the lock.
>
> Reported-by: syzbot+ec369e6d58e210135f71@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=ec369e6d58e210135f71
> Fixes: 31748765bed3 ("net: ethtool: pse-pd: Target the command to the requested PHY")
> Signed-off-by: Diogo Jahchan Koike <djahchankoike@gmail.com>
This looks good to me, thanks !
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Maxime
prev parent reply other threads:[~2024-08-30 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 18:48 Diogo Jahchan Koike
2024-08-30 16:27 ` Maxime Chevallier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240830182718.6ed8d8e2@device-28.home \
--to=maxime.chevallier@bootlin.com \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=djahchankoike@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+ec369e6d58e210135f71@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®